Repository navigation
馃攽 feat: Recover Enrolled Worker Credentials On Startup - #341
Open
lia-by-librechat[bot] wants to merge 1 commit into
Open
lia-by-librechat[bot] wants to merge 1 commit into
lia-by-librechat[bot] wants to merge 1 commit into
Conversation
Contributor
Author
Contributor
Author
|
Independent review completed for 2682b1c: no findings. Local build, no-emit typecheck, formatting, and 179 focused worker tests passed without a storage fixture. Live Code API/Redis/TLS restart verification was not run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Start slice 2 with automatic startup recovery. A worker stopped past its access-credential lifetime currently exits on refresh rejection even when Code API still holds its durable machine enrollment.
CREDENTIAL_INVALIDrefresh rejection invokes Code API's existing signed challenge/recovery flow.Independent of #339. This PR is the recovery portion of slice 2, not the
status/doctorcommands. Browser/OAuth approval from slice 1 is still outstanding.Verification
npm run buildandnpx --no-install tsc --noEmit: passed inpackages/code.Independent review
Reviewed head:
2682b1cc361ce94f65331ea9f73550bc816e85a2. Complete, no findings. Reviewer ran 47 recovery tests and 25 selected regressions with direct TypeScript execution. No live Code API/Redis/TLS restart test was performed.