test(Windows): stabilize tray notification CI test - #185
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #185 +/- ##
=======================================
Coverage 61.62% 61.62%
=======================================
Files 5 5
Lines 516 516
Branches 194 194
=======================================
Hits 318 318
- Misses 128 131 +3
+ Partials 70 67 -3
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
|
Screenshot ComparisonPR #185 screenshots vs Matrix:
|
| Image | Baseline | PR |
|---|---|---|
tray_icon_ico.png |
 |
 |
tray_icon_initial.png |
 |
 |
tray_icon_png.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_icon_update_ico.png |
 |
 |
tray_icon_update_png.png |
 |
 |
tray_icon_update_svg.png |
 |
 |
tray_icon_update_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_ico_icon.png |
 |
 |
tray_notification_png_icon.png |
 |
 |
tray_notification_svg_icon.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
tray_tooltip_hover.png |
 |
 |
Matrix: Linux-qt6
| Image | Baseline | PR |
|---|---|---|
tray_icon_ico.png |
 |
 |
tray_icon_initial.png |
 |
 |
tray_icon_png.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_icon_update_ico.png |
 |
 |
tray_icon_update_png.png |
 |
 |
tray_icon_update_svg.png |
 |
 |
tray_icon_update_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_ico_icon.png |
 |
 |
tray_notification_png_icon.png |
 |
 |
tray_notification_svg_icon.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
tray_tooltip_hover.png |
 |
 |
Matrix: Windows-qt6
| Image | Baseline | PR |
|---|---|---|
tray_icon_ico.png |
 |
 |
tray_icon_initial.png |
 |
 |
tray_icon_png.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_icon_update_ico.png |
 |
 |
tray_icon_update_png.png |
 |
 |
tray_icon_update_svg.png |
 |
 |
tray_icon_update_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_ico_icon.png |
 |
 |
tray_notification_png_icon.png |
 |
 |
tray_notification_svg_icon.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
tray_tooltip_hover.png |
 |
 |
Matrix: macOS-qt6
| Image | Baseline | PR |
|---|---|---|
tray_icon_ico.png |
 |
 |
tray_icon_initial.png |
 |
 |
tray_icon_png.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_icon_update_ico.png |
 |
 |
tray_icon_update_png.png |
 |
 |
tray_icon_update_svg.png |
 |
 |
tray_icon_update_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_ico_icon.png |
 |
 |
tray_notification_png_icon.png |
 |
 |
tray_notification_svg_icon.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
tray_tooltip_hover.png |
 |
 |
ReenigneArcher
force-pushed
the
test/fix-windows-notification
branch
from
September 6, 2026 15:39
7405a6c to
627b6ad
Compare
Improve `TestNotificationDisplay` reliability by waiting for Explorer to register the tray icon before dismissing notifications. The test now moves the mouse over the icon, waits for the tooltip, and restores mouse position to avoid timing-related flakiness.
ReenigneArcher
force-pushed
the
test/fix-windows-notification
branch
2 times, most recently
from
September 6, 2026 16:14
2ce963a to
ba46184
Compare
ReenigneArcher
changed the title
Pin the CI Windows runner to `windows-2022` because `windows-latest` suppresses `QSystemTrayIcon` notifications in the interactive session. Also add a `WaitForTrayReady()` step in `TestNotificationDisplay` so the tray icon is fully registered before notification handling, reducing timing-related test flakiness.
ReenigneArcher
force-pushed
the
test/fix-windows-notification
branch
from
September 6, 2026 16:31
ba46184 to
c322928
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pin the CI Windows runner to
windows-2022becausewindows-latestsuppressesQSystemTrayIconnotifications in the interactive session. Also add aWaitForTrayReady()step inTestNotificationDisplayso the tray icon is fully registered before notification handling, reducing timing-related test flakiness.Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.