Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/actions/configure-windows-tray-screenshots/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,23 @@ runs:
- name: Configure Windows tray screenshots
shell: pwsh
run: |
echo "::group::Use dark Windows appearance"
$personalizeSettings = "HKCU:\SOFTWARE\Microsoft\Windows\CurrentVersion\Themes\Personalize"
New-Item -Path $personalizeSettings -Force | Out-Null
New-ItemProperty `
-Path $personalizeSettings `
-Name "AppsUseLightTheme" `
-PropertyType DWord `
-Value 0 `
-Force | Out-Null
New-ItemProperty `
-Path $personalizeSettings `
-Name "SystemUsesLightTheme" `
-PropertyType DWord `
-Value 0 `
-Force | Out-Null
echo "::endgroup::"

echo "::group::Enable all tray icons"
$trayIconScript = Join-Path $env:RUNNER_TEMP "Enable-AllTrayIcons.ps1"
Invoke-WebRequest `
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ jobs:
- os: ubuntu-latest
shell: "bash"
qt_version: '6'
- os: windows-latest
# Windows Server 2022 renders QSystemTrayIcon notifications. The newer
# windows-latest image suppresses them in its interactive session.
- os: windows-2022
shell: "msys2 {0}"
qt_version: '6'
steps:
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/test_tray.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,9 @@ TEST_P(TrayNotificationIconTest, TestNotificationDisplay) {
int initResult = tray_init(&testTray);
trayRunning = (initResult == 0);
ASSERT_EQ(initResult, 0);

// Let the desktop shell process the new icon before sending its notification.
WaitForTrayReady();
dismissNativeNotifications();

// Set notification properties
Expand Down