Repository navigation
Parse table/Server/shadowExpeditionDrop.xml - #90
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a parser type for
table/Server/shadowExpeditionDrop.xml, the Shadow Expedition drop table: one row per stage (step, 1-34) and killed NPC class, naming the individual drop boxes that kill rolls. A server reviving the expedition needs it to drop that content's rewards, which no other table references. Bumps the package to 2.4.32.Xml/Table/Server/ShadowExpeditionDrop.cs: the row type.classis the NPC's basic class (1, 3 or 6, the classes whose npcrankIconis c, b and a), read as@classasNpc/Basicdoes.dropBoxIdis an[M2dArray]int list.ServerTableParser.ParseShadowExpeditionDrop(): yields the rows. They have no single id, so it yields the row itself, asParseNpcStatFactorByLeveldoes.ServerTableParserTest.TestShadowExpeditionDrop: pins the row count (102, steps 1-34 by classes 1, 3 and 6) and the first, second and last rows to the XML.Verification
dotnet test Maple2.File.Tests --filter TestShadowExpeditionDroppasses.TestBanWordParsercounts 7356 entries where it expects 6179), not parser failures.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.