Skip to content

Parse table/Server/shadowExpeditionDrop.xml - #90

Merged
Zintixx merged 2 commits into
masterfrom
feature-shadow-expedition-drop
Oct 28, 2026
Merged

Zintixx merged 2 commits into
masterfrom
feature-shadow-expedition-drop

Conversation

@Zintixx

@Zintixx Zintixx commented Oct 28, 2026 •

Copy link
Copy Markdown

Adds a parser type for table/Server/shadowExpeditionDrop.xml, the Shadow Expedition drop table: one row per stage (step, 1-34) and killed NPC class, naming the individual drop boxes that kill rolls. A server reviving the expedition needs it to drop that content's rewards, which no other table references. Bumps the package to 2.4.32.

  • Xml/Table/Server/ShadowExpeditionDrop.cs: the row type. class is the NPC's basic class (1, 3 or 6, the classes whose npc rankIcon is c, b and a), read as @class as Npc/Basic does. dropBoxId is an [M2dArray] int list.
  • ServerTableParser.ParseShadowExpeditionDrop(): yields the rows. They have no single id, so it yields the row itself, as ParseNpcStatFactorByLevel does.
  • ServerTableParserTest.TestShadowExpeditionDrop: pins the row count (102, steps 1-34 by classes 1, 3 and 6) and the first, second and last rows to the XML.

Verification

  • dotnet test Maple2.File.Tests --filter TestShadowExpeditionDrop passes.
  • The full suite gives the same 34 failures with and without this change, against the same local client data. They are data-dependent (for example TestBanWordParser counts 7356 entries where it expects 6179), not parser failures.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Zintixx and others added 2 commits October 27, 2026 21:21
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 24813529-ba0d-4d6d-9766-89557032fe69
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Zintixx
Zintixx merged commit 0ff5ce3 into master Oct 28, 2026
3 checks passed
@Zintixx
Zintixx deleted the feature-shadow-expedition-drop branch October 28, 2026 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant