Repository navigation
style(web): one layout for second sidebars, right rails and filter rails - #2009
Conversation
Settings rail rows match the app sidebar and name their sheet below lg. Right rails stop drawing a second border, width or card inside the kit rail. Filter rails pin option labels to 12px, share one right edge with the header, run the header rule edge to edge, and use shared group dividers and labels.
This comment has been minimized.
This comment has been minimized.
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
|
F1 fixed in 5853d89: |
🍁 Maple PR previewNote Preview resources were removed when this pull request closed. Final commit |
Maple review🟢 Confidence 10/10 · safe to merge. The head only adds a scene test that pins the This head adds one scene test asserting a
Fixed since the last review
|
Second sidebars, right rails and filter rails had drifted apart: each drew its own dividers, padding and type size, so the layout looked slightly off next to the app sidebar.
What changed
Settings / Account / Integrations rail
nav-shell.ts).lgthis rail opens as a sheet. It was labelled "Open filters" / "Filters"; a newfiltersLabelpage option makes it "Open settings" / "Settings" (or "Account settings"); the Kubernetes service rail gets "Services".Right rails
rightPanelWidthinstead.detailRailGroup, like the Cloudflare and GCP rails.bg-card/30tints (the error issue rail's stopped halfway down).Filter rails (all 16 already use
filterSidebarFrame/Header/Body)labelprimitive'ssm:text-sm/4beattext-xsat 640px and up. Pinned withsm:text-xs.filterSidebarDividerandfilterSidebarGroupLabelreplace hand-rolled group dividers and headings in logs, replays and web analytics, which used three different spacings.Screenshots
The local dev org has no telemetry, so the filter rail shots render the real filter components with sample facets inside the live
/tracespage. The infra, anomaly, recommendation and dashboard-history rails were not rendered with data; they are worth a look on the preview.Verification
bun run typecheckin apps/web and apps/local-ui (which reuses the rail lift), effect lint on the changed files: no errors.LiftedRailtype, unlabelled Kubernetes rail sheet) are fixed here.Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit