Skip to content

style(web): one layout for second sidebars, right rails and filter rails - #2009

Merged
Makisuo merged 2 commits into
mainfrom
style/web-sidebar-rail-polish
Oct 31, 2026
Merged

Makisuo merged 2 commits into
mainfrom
style/web-sidebar-rail-polish

test(web): a filtersLabel rail names its sheet and trigger

5853d89
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 31, 2026 in 15s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. The head only adds a scene test that pins the filtersLabel trigger and sheet names, closing F1; no other file changed since the earlier review.
no findings · tests covered · risk low

This head adds one scene test asserting a filtersLabel rail names both its top-bar trigger and its sheet, and that the old "Filters" button is gone. It closes the open finding and is safe to merge.

  • settingsView fixture renders a dashboardPage with filtersLabel: "Settings"
  • New scene test checks "Open filters" is absent, clicks "Open settings", asserts the "Settings" dialog holds the rail

Fixed since the last review

  • ✅ F1 · Rail label naming the sheet and trigger has no scene test
What was checked
  • filtersLabel reaches the rail: rail-label attribute (page/kit/dashboard-page.ts:72) read as rail.label (page-rails.ts:29)
  • Test would fail on regression: it asserts trigger name, absence of the old name, and dialog content view-page-sheets.ts:40,44,104

5853d89 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.