Skip to content

style(web): denser trace waterfall aligned with the traces list - #2010

Merged
Makisuo merged 1 commit into
mainfrom
style/waterfall-density
Oct 31, 2026
Merged

Makisuo merged 1 commit into
mainfrom
style/waterfall-density

Conversation

@Makisuo

@Makisuo Makisuo commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

The trace waterfall had drifted from the rest of the dashboard: rows were 36 to 40px with stacked padding, and the status, bar and header styling did not match the traces list or the Timeline tab.

Changes

  • Rows: a fixed 28px (h-7), the same as the agent-session waterfall. The virtualizer estimate goes from 33 to 28. The tree rails now stretch to the row instead of offsetting padding, so the call-path lines stay continuous.
  • Status column: HTTP codes, span status and Unset use the soft filled badges from the traces list. traceStatusBadge takes an optional className, and span status goes through severityTone.
  • Leaf squares: grey unless the span errored. Before, every Ok span had a green square, which repeated the status column.
  • Duration bars: coloured by service, as on the Timeline tab, instead of brand orange on every row. Errors stay red and HTTP warnings stay amber. One behaviour change: a span with status Error and an HTTP 4xx code now gets a red bar (it used to be amber).
  • Header: eyebrow labels, and the columns read Timeline / Duration / Status. Before, the bar column said "Duration" and the number column said "Time".

Verification

  • Rendered /lab/timeline (the real waterfall over a sample trace) in headless Chrome at 1440x900. Measured row heights went from 40px to 28px.
  • Waterfall and trace detail Vitest suites pass (51 tests), and typecheck and effect lint were clean on the branch these edits were first made on.
  • One independent review pass. It found no bugs, and its two simplifications are applied.

Screenshots

Before After
Dark before dark after dark
Light before light after light

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Rows are a fixed 28px (were 36-40px), matching the agent-session waterfall.
The status column uses the traces list's soft badges, leaf squares are
neutral unless the span errored, duration bars take the service colour like
the Timeline tab, and the header uses eyebrow labels (Timeline / Duration /
Status).
@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2ff0bf4f-1c54-4a76-bcfc-7f141329e6c6
Commits

Reviewing files that changed from the base of the PR and between 34ea16c and 92b329d.

Files selected for processing: 4
  • apps/web/src/page/traces/detail/waterfall/row.ts
  • apps/web/src/page/traces/detail/waterfall/view.ts
  • apps/web/src/page/traces/detail/waterfall/virtualize.ts
  • apps/web/src/ui/trace-badges.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@maple-review-bot

maple-review-bot Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 10/10 · safe to merge. Presentational only, and every helper the new classes call was read: tone maps, getServiceColor's raw oklch() output, and the badge/eyebrow signatures all line up.
no findings · tests not needed · risk low

Density pass on the trace waterfall: fixed 28px rows matching the virtualizer estimate, soft status badges shared with the traces list, per-service bar colours and eyebrow column labels. Presentational only; safe to merge.

  • Waterfall rows pinned to h-7 and ROW_HEIGHT lowered 33 to 28
  • Status cell renders traceStatusBadge / TONE_SOFT[severityTone()]
  • Duration bars take the service colour through an inline background-color
  • Leaf square flags only Error spans; header columns become eyebrows

92b329d · What was checked, coverage and telemetry details are on the Maple / review check. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@Makisuo Makisuo added the preview:web Deploy a Workers-only PR preview (no ingest/Electric); see docs/pr-previews.md label Oct 31, 2026
@Makisuo
Makisuo merged commit 9900c5d into main Oct 31, 2026
28 of 29 checks passed
@Makisuo
Makisuo deleted the style/waterfall-density branch October 31, 2026 01:30
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

🍁 Maple PR preview

Note

Preview resources were removed when this pull request closed.

Final commit 92b329d · View workflow run

@Makisuo
Makisuo deployed to pr-preview October 31, 2026 01:31 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
pr-preview — 92b329da Deployed Oct 31, 2026 by Makisuo via deploy-pr-preview #8082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview:web Deploy a Workers-only PR preview (no ingest/Electric); see docs/pr-previews.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant