Repository navigation
style(web): denser trace waterfall aligned with the traces list - #2010
Conversation
Rows are a fixed 28px (were 36-40px), matching the agent-session waterfall. The status column uses the traces list's soft badges, leaf squares are neutral unless the span errored, duration bars take the service colour like the Timeline tab, and the header uses eyebrow labels (Timeline / Duration / Status).
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Maple review🟢 Confidence 10/10 · safe to merge. Presentational only, and every helper the new classes call was read: tone maps, Density pass on the trace waterfall: fixed 28px rows matching the virtualizer estimate, soft status badges shared with the traces list, per-service bar colours and eyebrow column labels. Presentational only; safe to merge.
|
🍁 Maple PR previewNote Preview resources were removed when this pull request closed. Final commit |
The trace waterfall had drifted from the rest of the dashboard: rows were 36 to 40px with stacked padding, and the status, bar and header styling did not match the traces list or the Timeline tab.
Changes
h-7), the same as the agent-session waterfall. The virtualizer estimate goes from 33 to 28. The tree rails now stretch to the row instead of offsetting padding, so the call-path lines stay continuous.traceStatusBadgetakes an optionalclassName, and span status goes throughseverityTone.Verification
/lab/timeline(the real waterfall over a sample trace) in headless Chrome at 1440x900. Measured row heights went from 40px to 28px.Screenshots
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.