Skip to content

style(web): denser trace waterfall aligned with the traces list - #2010

Merged
Makisuo merged 1 commit into
mainfrom
style/waterfall-density
Oct 31, 2026
Merged

Makisuo merged 1 commit into
mainfrom
style/waterfall-density

style(web): denser trace waterfall aligned with the traces list

92b329d
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 31, 2026 in 44s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. Presentational only, and every helper the new classes call was read: tone maps, getServiceColor's raw oklch() output, and the badge/eyebrow signatures all line up.
no findings · tests not needed · risk low

Density pass on the trace waterfall: fixed 28px rows matching the virtualizer estimate, soft status badges shared with the traces list, per-service bar colours and eyebrow column labels. Presentational only; safe to merge.

  • Waterfall rows pinned to h-7 and ROW_HEIGHT lowered 33 to 28
  • Status cell renders traceStatusBadge / TONE_SOFT[severityTone()]
  • Duration bars take the service colour through an inline background-color
  • Leaf square flags only Error spans; header columns become eyebrows
What was checked
  • getServiceColor returns oklch() text, so the bar colour belongs in h.Style, and inline background-color is the repo idiom (apps/web/src/charts/*)
  • severityTone maps Ok/Error/Unset/"" to ok/crit/neutral, so the span-status badge keeps its old tones (packages/ui/src/lib/tone.ts:59)
  • ROW_HEIGHT = 28 equals h-7; waterfall.scene.test.ts pins behaviour, not row heights, so nothing goes stale

92b329d · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.