Repository navigation
feat(web): technology and runtime marks in the trace waterfall - #2046
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Nov 1, 2026 in 1m 10s
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge. Resolver and row rendering are pinned by tech.test.ts and the waterfall scene test; the narrow-width kind-label hide rests on preview screenshots.
no findings · tests covered · risk medium
The waterfall now marks what each span called (gen_ai, db, messaging, rpc) and what runs each service (Worker, Effect, or runtime), backed by four more projected span and resource keys. The resolver, the row changes and the Color-by fix added since the last review hold up.
spanTechpicks the called system by gen_ai, db, messaging, then rpc precedenceserviceMarkprefers the Worker mark, thenserviceRuntime(Effect, runtime, SDK language)spanHierarchyQueryprojects 4 more span and 4 more resource attribute keyscountKeysskips the query's empty""projections so Color-by offers only real keys
Production impact
Telemetry this change adds and removes (2)
- ➕ attribute
rpc.system·packages/query-engine/src/__sql_baseline__/catalog.sql:13915 - ➕ attribute
gen_ai.system·packages/query-engine/src/__sql_baseline__/catalog.sql:13915
What was checked
pickAttrdiscards blank values (cloud-platforms.ts:67), so the query's""projections never produce a mark- Prod reports
cloud.platform=cloudflare.workerson the resource only, which the newserviceMarkcheck reads - Every
DbIconKeyresolves throughDB_ICON, whichsatisfies Record<DbIconKey, IconName>(node-card.ts:45)
8f2c591 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading