Fix: first DMG pass signed before the certificate existed - #10
Open
MasterYoav wants to merge 1 commit into
Open
MasterYoav wants to merge 1 commit into
MasterYoav wants to merge 1 commit into
Conversation
CI builds the DMG twice — unsigned first, then again after the import step. Keyed on the identity's name alone, the first pass failed the release with "no identity found". It now signs only when the identity is in a keychain. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first signed release failed at Create DMG with
no identity found— my bug from #5. CI runscreate-dmg.shbefore the certificate is imported (to produce an unsigned DMG when there are no secrets) and again fromsign-mac-app.shafterwards. Signing keyed onMACOS_SIGNING_IDENTITYbeing set broke the first pass.Now it signs only when
security find-identityactually finds the identity. Verified both paths locally: a named-but-absent identity builds unsigned; the real one signs the uninstaller (TeamIdentifier N6883L5366).🤖 Generated with Claude Code