Skip to content

Fix: first DMG pass signed before the certificate existed #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MasterYoav wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: first DMG pass signed before the certificate existed #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion scripts/create-dmg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,13 @@ chmod +x "${STAGE}/Uninstall xBot.command"
# and the disk image preserve those. Unsigned, it arrives quarantined from a download and macOS
# refuses it as coming from an unidentified developer — which, for the person who already trashed
# the app and wants their volumes back, is a dead end with no second path.
if [[ -n "${MACOS_SIGNING_IDENTITY:-}" ]]; then
#
# Only when the identity is actually in a keychain, not merely named. In CI this script runs twice:
# once before the certificate is imported (an unsigned DMG, so a run with no secrets still produces
# one) and again from sign-mac-app.sh afterwards. Keyed on the name alone, the first pass failed the
# release with "no identity found".
if [[ -n "${MACOS_SIGNING_IDENTITY:-}" ]] \
&& security find-identity -v -p codesigning | grep -qF "${MACOS_SIGNING_IDENTITY}"; then
codesign --force --timestamp --sign "${MACOS_SIGNING_IDENTITY}" \
"${STAGE}/Uninstall xBot.command"
fi
Expand Down
Loading