Repository navigation
fix(dsh): use producer-owned source kind for Session format v4 compatibility - #2455
Closed
bobbyreader wants to merge 1 commit into
Closed
bobbyreader wants to merge 1 commit into
bobbyreader wants to merge 1 commit into
Conversation
…ibility
In DeepSeek Harness >= 0.10.0 (Session format v4), message sources with
kind: 'plugin' are retired and rejected with:
SessionFormatError: format v4 message requires a producer-owned source kind
Update deepseek-harness adapter to use producer-owned source kind
plugin:${DEEPSEEK_HARNESS_PLUGIN} for recall messages and host LLM helper
messages, and update unit tests accordingly.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Memtensor-AI
added
area:plugin
4 of 5 tasks
Collaborator
|
Thank you for the fix and the live DSH validation. The changes in this PR—updating both recall and auxiliary host-LLM messages to producer-owned source kinds, together with the corresponding test expectations—have been covered by #2519, which is merged and released in @memtensor/memos-local-plugin 2.0.21. The merged implementation also includes regression coverage using the official V4 admission validator and Windows Desktop automatic-recall verification. Closing this PR as superseded by #2519. Thank you for helping identify and validate the compatibility fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
SessionFormatError: format v4 message requires a producer-owned source kindin DeepSeek Harness (DSH >= 0.10.0 / Session format v4).Problem
In DSH 0.10.0 (Session format v4), message sources with
kind: 'plugin'have been deprecated and rejected in favor of producer-owned source kinds (plugin:<plugin-name>). When@memtensor/memos-local-plugininjected memory recall context or created auxiliary user messages for host LLM calls withsource: { kind: 'plugin', plugin: 'memos-local-memory' }, DSH's session format validator rejected the message and crashed the session turn during projection/persistence.Fix
createRecallMessageinadapters/deepseek-harness/index.tsto usesource: { kind: \plugin:${DEEPSEEK_HARNESS_PLUGIN}`, form: 'recall' }`.toDshMessageinadapters/deepseek-harness/host-llm.tsto usesource: { kind: \plugin:${HOST_LLM_MESSAGE_SOURCE}` }`.deepseek-harness-bridge.test.tsanddeepseek-harness-host-llm.test.ts.Validation
🤖 Generated with Claude Code