Skip to content

fix(dsh): use producer-owned source kind for Session format v4 compatibility #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bobbyreader wants to merge 1 commit into from
Closed

fix(dsh): use producer-owned source kind for Session format v4 compatibility #2455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/memos-local-plugin/adapters/deepseek-harness/host-llm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ function toDshMessage(
if (message.role === "user") {
return createUserMessage({
content,
source: { kind: "plugin", plugin: HOST_LLM_MESSAGE_SOURCE },
source: { kind: `plugin:${HOST_LLM_MESSAGE_SOURCE}` },
});
}
return createAssistantMessage({
Expand Down
3 changes: 1 addition & 2 deletions apps/memos-local-plugin/adapters/deepseek-harness/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,8 +387,7 @@ export async function apply(
createRecallMessage: (text) => createUserMessage({
content: [{ type: "text", text }],
source: {
kind: "plugin",
plugin: DEEPSEEK_HARNESS_PLUGIN,
kind: `plugin:${DEEPSEEK_HARNESS_PLUGIN}`,
form: "recall",
},
}) as unknown as DshUserMessageLike,
Expand Down
20 changes: 9 additions & 11 deletions apps/memos-local-plugin/tests/unit/adapters/deepseek-harness-bridge.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ function recallMessage(text: string): DshUserMessageLike {
role: "user",
content: [{ type: "text", text }],
source: {
kind: "plugin",
plugin: "memos-local-memory",
kind: "plugin:memos-local-memory",
form: "recall",
},
};
Expand Down Expand Up @@ -539,8 +538,7 @@ describe("DeepSeek Harness bridge", () => {
expect(first.messages[1]).toMatchObject({
role: "user",
source: {
kind: "plugin",
plugin: "memos-local-memory",
kind: "plugin:memos-local-memory",
form: "recall",
},
content: [{
Expand All @@ -553,7 +551,7 @@ describe("DeepSeek Harness bridge", () => {
expect(followUp).toMatchObject({
kind: "enter",
messages: [followUpPrompt, expect.objectContaining({
source: expect.objectContaining({ plugin: "memos-local-memory" }),
source: expect.objectContaining({ kind: "plugin:memos-local-memory" }),
})],
});
});
Expand Down Expand Up @@ -590,7 +588,7 @@ describe("DeepSeek Harness bridge", () => {
expect(result).toMatchObject({
kind: "enter",
messages: [prompt, expect.objectContaining({
source: expect.objectContaining({ plugin: "memos-local-memory" }),
source: expect.objectContaining({ kind: "plugin:memos-local-memory" }),
})],
});
expect(core.searchMemory).toHaveBeenCalledTimes(1);
Expand Down Expand Up @@ -637,7 +635,7 @@ describe("DeepSeek Harness bridge", () => {
expect(result).toMatchObject({
kind: "enter",
messages: [prompt, expect.objectContaining({
source: expect.objectContaining({ plugin: "memos-local-memory" }),
source: expect.objectContaining({ kind: "plugin:memos-local-memory" }),
})],
});
});
Expand Down Expand Up @@ -682,7 +680,7 @@ describe("DeepSeek Harness bridge", () => {
expect(result).toMatchObject({
kind: "enter",
messages: [prompt, expect.objectContaining({
source: expect.objectContaining({ plugin: "memos-local-memory" }),
source: expect.objectContaining({ kind: "plugin:memos-local-memory" }),
})],
});
expect(core.searchMemory).toHaveBeenCalledTimes(1);
Expand Down Expand Up @@ -836,7 +834,7 @@ describe("DeepSeek Harness bridge", () => {
expect(result).toMatchObject({
kind: "enter",
messages: [retry, expect.objectContaining({
source: expect.objectContaining({ plugin: "memos-local-memory" }),
source: expect.objectContaining({ kind: "plugin:memos-local-memory" }),
})],
});

Expand Down Expand Up @@ -959,7 +957,7 @@ describe("DeepSeek Harness bridge", () => {
await expect(nextStep).resolves.toMatchObject({
kind: "enter",
messages: [secondPrompt, expect.objectContaining({
source: expect.objectContaining({ plugin: "memos-local-memory" }),
source: expect.objectContaining({ kind: "plugin:memos-local-memory" }),
})],
});
expect(core.searchMemory).toHaveBeenCalledTimes(2);
Expand Down Expand Up @@ -1037,7 +1035,7 @@ describe("DeepSeek Harness bridge", () => {
await expect(nextStep).resolves.toMatchObject({
kind: "enter",
messages: [secondPrompt, expect.objectContaining({
source: expect.objectContaining({ plugin: "memos-local-memory" }),
source: expect.objectContaining({ kind: "plugin:memos-local-memory" }),
})],
});
expect(core.searchMemory).toHaveBeenCalledTimes(2);
Expand Down
2 changes: 1 addition & 1 deletion apps/memos-local-plugin/tests/unit/adapters/deepseek-harness-host-llm.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ describe("DeepSeek Harness host LLM bridge", () => {
{
role: "user",
content: [{ type: "text", text: "Question" }],
source: { kind: "plugin", plugin: "memos-local-memory" },
source: { kind: "plugin:memos-local-memory" },
},
{
role: "assistant",
Expand Down
Loading