Repository navigation
Require workspace storage for microsandbox - #815
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
SaladDay
force-pushed
the
require-workspace-storage-for-microsandbox
branch
from
October 21, 2026 20:57
936397f to
9fae750
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microsandbox now runs every Environment on external workspace storage (the
nfsadapter). Its Provider-owned disk mode is gone from the Provider, its helper, Core, Web, the generated projections, the node installer, docs and tests. Docker and E2B keep their own disks.DeploymentPolicy.Workspacepresent means the Provider runs every Environment on external storage. A deployment of such a Provider with no storage selected returnsErrWorkspaceRequired, reported as 409workspace_storage_required.environment_disk_mibthere is only a capacity quota request (default 0).retained_native_history, so the existing rule rejects it on microsandbox. The rejection is nowsessions.ErrRetainedHistoryUnsupported, reported as 400unsupported_or_invalid_configurationwith the reason instead of the generic invalid-request message; the compatibility record and Session admission table say so.oac-nodewith Core's UID 65532 and stops with nothing changed when another account holds that UID or an existingoac-nodeuses another UID. The manual precreate step is gone from the docs.Checks: Core
go vet ./...;go testfor sandbox, deployment, deploymentpg, execution, api, cmd/server and the whole integration package (its Worker fixture now builds workspace storage ascmd/serverdoes); helper tests with the bundled SDK (scripts/build-microsandbox-provider.py test);pytest deploy/node; agents-client typecheck and tests; Web typecheck and sandbox/i18n tests; translation check. Real-cluster run on mx (together with #816): 409 before storage is selected, the Web hint,oac-nodeadopted with UID 65532, Codex and Claude Code hosted acceptance 9/9 each, preparation cache and resume probes correct. Playwright cases run in CI only (no browser on the dev server).Need help on this PR? Tag
@codesmith-botwith what you need.