Repository navigation
Keep microsandbox checkpoints as native snapshots - #816
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
SaladDay
force-pushed
the
require-workspace-storage-for-microsandbox
branch
from
October 21, 2026 20:57
936397f to
9fae750
Compare
SaladDay
force-pushed
the
keep-microsandbox-checkpoints-as-native-snapshots
branch
from
October 21, 2026 20:57
9fdfcff to
1413892
Compare
Base automatically changed from
require-workspace-storage-for-microsandbox
to
main
October 21, 2026 21:04
SaladDay
force-pushed
the
keep-microsandbox-checkpoints-as-native-snapshots
branch
from
October 21, 2026 21:04
1413892 to
2bfafe7
Compare
SaladDay
deleted the
keep-microsandbox-checkpoints-as-native-snapshots
branch
October 21, 2026 21:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #815.
A microsandbox suspend exported the native snapshot to a zstd archive, fsynced and hashed it, then deleted the native snapshot; every resume hashed and unpacked the archive again. On mx that export was 2.73 s of a 5.85 s suspend and about 0.9 s of each resume.
Now the native snapshot is the checkpoint:
SnapshotCreateOptions.DestDir, groups-<operation>). The SDK materializes the checkpoint closure there (hard links on the same filesystem, otherwise a synced copy) and returns it durable. The adapter verifies it once, writes the ownership receipt, stops the source, then reportsSourceStopped.Cost: a retained checkpoint takes about 0.5 GB instead of about 0.15 GB, and a shared checkpoint root receives a full copy at suspend.
Checks: helper tests with the bundled SDK (
scripts/build-microsandbox-provider.py test),go testforinternal/sandbox/microsandbox, Corego vet ./internal/sandbox/..., translation check. Real-cluster timings on mx are in progress.Need help on this PR? Tag
@codesmith-botwith what you need.