test(tutor-quality): keep only the coverage lower bound for strategy cases (R-AUT-1) - #156
Merged
Merged
Conversation
…cases (R-AUT-1) The corpus contract test capped the judge-enabled strategy cases per phase at three. EXPAND already has three, so any further valid EXPAND case would fail the test, although R-AUT-1 forbids hard-coding the case count and §1 lets new cases be corpus data only. The test keeps the lower bound of two per phase. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Conformance finding from the Tutor SSOT audit: Evaluation SSOT R-AUT-1 says "Tests MUST NOT hard-code the full list of case IDs or the case count. They assert structural invariants", and §1 says new quality cases are corpus data only.
Finding
anchor-corpus.test.ts › contains two judge-enabled strategy cases for each learning phaseassertedcount >= 2 && count <= 3per phase. EXPAND already has three Strategy cases, so any further valid EXPAND case would fail this contract test and require a test change.Change
The test keeps the coverage lower bound (at least two judge-enabled Strategy cases per phase). The upper bound is removed. No corpus, runner, or product change.
TDD
strategy-expand-proposalunder a new ID; never committed), the test failed.Gates
npm run test:tutor-quality407 passed, ESLint clean for the file, pre-push (check, unit, Sonar) passed.🤖 Generated with Claude Code