fix(reporter): sort log tabs alphabetically instead of by creation time - #59
Merged
Merged
Conversation
sortLogFiles() sorted by file creation time, reversed (newest first). With two log files from one session (Terasology-init.log, Terasology-menu.log) that reads as arbitrary - neither the order they were written in nor the order their names suggest - rather than a deliberate choice. Sorting by filename instead is deterministic and, for Terasology's own log naming, happens to match session order too. Also carries the GlobalProperties NPE guard from #56 (needed to construct GlobalProperties() at all in cr-core's own test classpath, same as there - see that PR for the full explanation). Will collapse to a no-op merge once #56 lands first. First item from #53 (1 of 5); items 2 and 3 are #56 and #58. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 22, 2026
BenjaminAmos
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sortLogFiles()sorted by file creation time, reversed (newest first). With two log files from one session (Terasology-init.log,Terasology-menu.log) that reads as arbitrary - neither the order they were written in nor the order their names suggest - rather than a deliberate choice, per the original issue's own framing. Sorting by filename instead is deterministic and, for Terasology's own log naming, happens to match session order too.GlobalPropertiesNPE guard from fix(reporter): include every log file in the PasteBin upload #56 - needed just to constructGlobalProperties()at all incr-core's own test classpath, same reasoning as there. Will collapse to a no-op merge once fix(reporter): include every log file in the PasteBin upload #56 lands first, since it's the identical diff.First item from #53 (1 of 5); items 2 and 3 are #56 and #58.
Test plan
ErrorMessagePanelTabOrderTest- writes two log files out of alphabetical order with a real gap between creation times, asserts the resulting tab order is alphabetical regardless../gradlew build- clean.Related