Skip to content

Show a small map's controls only on request, behind a button in the map - #227

Merged
vadi2 merged 3 commits into
mainfrom
ccr-14671218-tf96z6-map-controls
Nov 19, 2026
Merged

vadi2 merged 3 commits into
mainfrom
ccr-14671218-tf96z6-map-controls

Conversation

@vadi2

@vadi2 vadi2 commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Brief overview of PR changes/additions

  • A small map in a corner (a script's small mapper, and the app's map in the corner) shows only a small button in its top corner instead of its whole panel of controls.
  • The button shows the panel; the button, Back or a touch elsewhere hides it again.
  • The panel is as wide as the map or three buttons, not four; the area name and level wrap in it rather than being cut short.
  • TalkBack reads the map, the button, then the panel; the map's own actions work without opening it. The button's labels come from strings.xml.
  • The app map's hide button uses a "visibility off" icon, not a second X beside the close button.

Motivation for adding to Mudlet

On a phone the small map's controls were wider than the map and covered the game's text. A player asked to put them behind a small button inside the map.

Other info (issues closed, discussion etc)

Part of Mudlet/Mudlet#9011
Desktop shows its mapper's panel until the player hides it, so hiding it by default is in docs/divergences.md.
Checked: ktlint, lint.sh strings/conflict-markers, MapCornerTest (red at the old width); CI: green, PTB: green, size: ptb-arm64-v8a 82.15 MB of 81.98 MB (within the 5% headroom); bite: red, each test for its own reason (no button in the app map, Back leaves the game screen, the panel stays after a touch elsewhere or the button, the button on the wrong side in ar-XB); device-only: the button's look over a real map.

🤖 Generated with Claude Code

https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J

A script's small mapper and the app's map in the corner drew their panel
of controls beside the map all the time, as wide as four buttons and
wider than a phone's map, over the game's text. Now only a small button
over the map's top corner shows; it opens the panel, which the button,
Back or a touch elsewhere put away again. The panel is as wide as three
buttons or the map. TalkBack reads the map, the button, then the panel,
and the map's own actions still zoom, pan and change level without it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
… controls' button where it is

The panel is three buttons wide now, too narrow for an area name in two lines in en-XA; it scrolls, so the name
takes the lines it needs. The controls' button is over the map, not in the panel's scroll, so the test clicks it
without scrolling to it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
Between two 48 dp buttons in a panel three buttons wide, en-XA's level needs more than two lines.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
@vadi2
vadi2 force-pushed the ccr-14671218-tf96z6-map-controls branch from b92ba39 to d94a8a0 Compare November 19, 2026 19:20
@vadi2
vadi2 merged commit 25d3285 into main Nov 19, 2026
21 checks passed
@vadi2
vadi2 deleted the ccr-14671218-tf96z6-map-controls branch November 19, 2026 19:52
vadi2 pushed a commit that referenced this pull request Nov 19, 2026
The status table's rows for what merged since #220: opening a shared .zip
with Mudlet finishes lane 3 (#224), and the SOCKS5 proxy (engine train 7,
#223) finishes IF5. Also in: a selection across lines (#225), a profile's
log files shared or opened (#222), patch 0004 rebased on
Mudlet/Mudlet#12937 (engine train 8, #228) and the corner map's controls
behind a button (#227).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
vadi2 added a commit that referenced this pull request Nov 19, 2026
docs/plan.md's status table brought up to date with today's merges: IF3 (#228, patch 0004), IF5 done (#223, a profile's SOCKS5 proxy), IF6 (#222, a profile's log files), 3 done (#224, open a shared .zip with Mudlet), 6 (#225, a selection across lines) and 10 (#227, a corner map's controls behind a button). Existing rows changed in place; none added.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants