Repository navigation
Show a small map's controls only on request, behind a button in the map - #227
Merged
Merged
Conversation
vadi2
force-pushed
the
ccr-14671218-tf96z6-map-controls
branch
from
November 19, 2026 16:46
cdbd6e7 to
87dc214
Compare
A script's small mapper and the app's map in the corner drew their panel of controls beside the map all the time, as wide as four buttons and wider than a phone's map, over the game's text. Now only a small button over the map's top corner shows; it opens the panel, which the button, Back or a touch elsewhere put away again. The panel is as wide as three buttons or the map. TalkBack reads the map, the button, then the panel, and the map's own actions still zoom, pan and change level without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
… controls' button where it is The panel is three buttons wide now, too narrow for an area name in two lines in en-XA; it scrolls, so the name takes the lines it needs. The controls' button is over the map, not in the panel's scroll, so the test clicks it without scrolling to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
Between two 48 dp buttons in a panel three buttons wide, en-XA's level needs more than two lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
vadi2
force-pushed
the
ccr-14671218-tf96z6-map-controls
branch
from
November 19, 2026 19:20
b92ba39 to
d94a8a0
Compare
vadi2
pushed a commit
that referenced
this pull request
Nov 19, 2026
The status table's rows for what merged since #220: opening a shared .zip with Mudlet finishes lane 3 (#224), and the SOCKS5 proxy (engine train 7, #223) finishes IF5. Also in: a selection across lines (#225), a profile's log files shared or opened (#222), patch 0004 rebased on Mudlet/Mudlet#12937 (engine train 8, #228) and the corner map's controls behind a button (#227). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
vadi2
added a commit
that referenced
this pull request
Nov 19, 2026
docs/plan.md's status table brought up to date with today's merges: IF3 (#228, patch 0004), IF5 done (#223, a profile's SOCKS5 proxy), IF6 (#222, a profile's log files), 3 done (#224, open a shared .zip with Mudlet), 6 (#225, a selection across lines) and 10 (#227, a corner map's controls behind a button). Existing rows changed in place; none added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Motivation for adding to Mudlet
On a phone the small map's controls were wider than the map and covered the game's text. A player asked to put them behind a small button inside the map.
Other info (issues closed, discussion etc)
Part of Mudlet/Mudlet#9011
Desktop shows its mapper's panel until the player hides it, so hiding it by default is in docs/divergences.md.
Checked: ktlint, lint.sh strings/conflict-markers, MapCornerTest (red at the old width); CI: green, PTB: green, size: ptb-arm64-v8a 82.15 MB of 81.98 MB (within the 5% headroom); bite: red, each test for its own reason (no button in the app map, Back leaves the game screen, the panel stays after a touch elsewhere or the button, the button on the wrong side in ar-XB); device-only: the button's look over a real map.
🤖 Generated with Claude Code
https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J