Exclude the Incus loop file from host disk free-percent - #393
Merged
Conversation
compute_root_disk_low used the OTel root filesystem ratio, which counts the 200 GiB loop-backed thin pool as tenant-used space. With discards=nopassdown that file stays fully allocated while pool data_percent is ~20%, so the ticket fired at 17-18% free of the whole disk. Admission and the ticket now use the observer percent of remaining host space; placement already reads the thin pool.
internal/hostprobe is part of the provider derivative. Moving the loop-file exclusion into internal/hostdisk and gha-fleet-observer lets the ticket use the corrected percent without a provider release. Admission still uses raw statvfs until the next provider identity.
rldyourmnd
force-pushed
the
fix/disk-percent-excludes-loop-file
branch
from
September 3, 2026 22:30
319d9b8 to
f9a2752
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Live members: 309 GiB root, 200 GiB fully allocated
/var/lib/incus/disks/gha-lvm.img, thin pooldata_percent~21%.compute_root_disk_lowusedsystem_filesystem_usageon/, so it reported 17–18% free of the whole disk and paged every silence window.That is the loop file, not tenant data.
docs/maintenance-windows.mdalready says capacity alerts must not treat the apparent file size as live tenant data. Placement already uses the Incus thin pool.Change
hostprobefree-percent excludes Incus*.imgloop files on the same devicecompute_root_disk_lowreadsgha_fleet_host_root_free_percentwith threshold 20Live check (before this lands)