fix(release): publish prefill-router before switchyard-runner - #707
Conversation
Signed-off-by: nachiketb <nachiketb@nvidia.com>
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review. WalkthroughThe Rust release workflow now validates and publishes ChangesRust crate release workflow
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The release-order and documentation updates align with the dependency chain, with no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
A rabbit checks the crate list with care Comment |
What
prefill-routerbeforeswitchyard-runnerin the Rust release job.Why
switchyard-runnerhas a versioned optional dependency onprefill-router. Cargo resolves that dependency while preparing the package even when the feature is disabled. The release job omitted the dependency, so runner publication stopped andswitchyard-servercould not be published afterward.How
The existing idempotent
publish_cratehelper now publishesprefill-routerafter its library dependencies and waits for it to reach the crates.io index before publishingswitchyard-runner. Existing versions are still skipped.Validation
cargo package --locked -p prefill-router --no-verifyprefill-routerpackaged 14 required files successfully.actionlintpassed for.github/workflows/publish.yml.Fixes SWITCH-1444.
Summary by CodeRabbit
prefill-routercrate in dependency order.