Skip to content

fix(release): publish prefill-router before switchyard-runner - #707

Merged
ayushag-nv merged 1 commit into
mainfrom
nachiketb/fix-rust-publish-prefill-router
Sep 15, 2026
Merged

ayushag-nv merged 1 commit into
mainfrom
nachiketb/fix-rust-publish-prefill-router

Conversation

@nachiketb-nvidia

@nachiketb-nvidia nachiketb-nvidia commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

What

  • Publish prefill-router before switchyard-runner in the Rust release job.
  • Validate its version against the release tag with the other published crates.
  • Document the complete seven-crate publication order and token requirement.

Why

switchyard-runner has a versioned optional dependency on prefill-router. Cargo resolves that dependency while preparing the package even when the feature is disabled. The release job omitted the dependency, so runner publication stopped and switchyard-server could not be published afterward.

How

The existing idempotent publish_crate helper now publishes prefill-router after its library dependencies and waits for it to reach the crates.io index before publishing switchyard-runner. Existing versions are still skipped.

Validation

  • cargo package --locked -p prefill-router --no-verify
  • prefill-router packaged 14 required files successfully.
  • actionlint passed for .github/workflows/publish.yml.
  • Repository pre-commit hooks passed.
  • No crate was published and no tag was created.

Fixes SWITCH-1444.

Summary by CodeRabbit

  • Release Process
    • The release workflow now validates and publishes the prefill-router crate in dependency order.
    • The release process now covers seven crates, and the configured crates.io token must authorize publishing all of them.

Signed-off-by: nachiketb <nachiketb@nvidia.com>
@nachiketb-nvidia
nachiketb-nvidia requested a review from a team as a code owner September 15, 2026 18:56
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1

🚀 View preview at
https://NVIDIA-NeMo.github.io/Switchyard/pr-preview/pr-707/

Built to branch gh-pages at 2026-09-15 18:57 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: bd039ce2-1fb9-471b-a130-33601dfe70a6

📥 Commits

Reviewing files that changed from the base of the PR and between 3807ff0 and a4c27e1.

📒 Files selected for processing (2)
  • .github/workflows/publish.yml
  • docs/internal/release_workflow.md

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.


Walkthrough

The Rust release workflow now validates and publishes prefill-router in dependency order. The release documentation now lists seven crates and requires a token authorized to publish all seven.

Changes

Rust crate release workflow

Layer / File(s) Summary
Crate validation, publication, and release documentation
.github/workflows/publish.yml, docs/internal/release_workflow.md
The workflow validates and publishes prefill-router before switchyard-runner. The documentation updates the publication order, crate count, and token requirement.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to a4c27

The release-order and documentation updates align with the dependency chain, with no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main release-order fix: publishing prefill-router before switchyard-runner.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

A rabbit checks the crate list with care
prefill-router joins the publish pair
Seven crates hop in ordered line
The token grants each crate its sign
Release notes now match the plan

Comment @coderabbitai help to get the list of available commands.

@ayushag-nv
ayushag-nv merged commit 9c774d2 into main Sep 15, 2026
21 checks passed
@ayushag-nv
ayushag-nv deleted the nachiketb/fix-rust-publish-prefill-router branch September 15, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants