Skip to content

fix: validate health configuration before credential skips - #46

Draft
binaryaaron wants to merge 1 commit into
codex/usersim-draft-pr01-toolsfrom
codex/usersim-draft-pr02-health
Draft

binaryaaron wants to merge 1 commit into
codex/usersim-draft-pr01-toolsfrom
codex/usersim-draft-pr02-health

Conversation

@binaryaaron

Copy link
Copy Markdown

What changed and why

Distinguish successful, missing-credential and failed health outcomes. Validate model parameters before classifying credential skips, using the existing model conversion API.

Stack position: 2/12. Base: codex/usersim-draft-pr01-tools. Merge in stack order.

How it was verified

The unchanged candidate has a strict schema-v3 Arc acceptance. Offline health regressions cover invalid parameters before credential skips and preserved outcome handling.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

@binaryaaron

Copy link
Copy Markdown
Author

recheck

Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
@binaryaaron
binaryaaron force-pushed the codex/usersim-draft-pr01-tools branch from 7b53cfe to d13d5ef Compare October 16, 2026 15:30
@binaryaaron
binaryaaron force-pushed the codex/usersim-draft-pr02-health branch from f2b6bd4 to 51d3406 Compare October 16, 2026 15:30
@3mei

3mei commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

@binaryaaron Good direction, but could we please resubmit it on its own from main (it's stacked on #45 now), with scripts/check_health.py, its tests, and the Makefile and workflow wiring. CONTRIBUTING already documents make health-check, so update it there rather than adding a docs/engineering/ page; the docs are being reorganized for a documentation site, and a new tree would need folding in again.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants