Skip to content

Fix uninitialized x64 handle in CUtlHandleTable::CreateHandle #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunzenshen wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −4
Open

Fix uninitialized x64 handle in CUtlHandleTable::CreateHandle #2118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/public/tier1/utlhandletable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,12 +290,11 @@ UtlHandle_t CUtlHandleTable<T, HandleBits>::CreateHandle( unsigned int nSerial,
// but that'd widen the object from 4 bytes of data to 4+4 padding, which would need profiling.
static_assert(sizeof(h) == 4);
static_assert(sizeof(UtlHandle_t) >= sizeof(h));
UtlHandle_t ret;
UtlHandle_t ret = 0;
memcpy(&ret, &h, sizeof(h));
#if defined(DBGFLAG_ASSERT) && defined(ACTUALLY_COMPILER_MSVC)
UtlHandle_t ref;
ref = *(UtlHandle_t*)&h;
Assert(ret == ref);
Assert(GetListIndex(ret) == nIndex);
Assert(GetSerialNumber(ret) == nSerial);
#endif
return ret;
#else
Expand Down