docs: fix test count, document permission-aware auth + tenancy gate, add structure - #3
Merged
Merged
Conversation
…add structure
- Testing: README said "48 tests passing, 93% coverage". Live run
today: 90 tests, 95% coverage.
- New "Permission-aware authorization" section: app/core/permissions.py's
ACTION_PERMISSION_MAP is the receiving end of omnibioai-api-gateway's
own SERVICE_PERMISSION_MAP (documented in that repo's README last
turn) -- a real, currently-active gate checking the requester's
`permissions` claim against omnibioai-auth's registry strings
(workflow.execute, model.use, dataset.read). "Core Features" only
described generic RBAC/ABAC before; this gate wasn't mentioned
anywhere.
- New "Org-tenancy scoping" section + Roadmap correction: the Roadmap
said "Org-level multi-tenancy | Planned v0.5", reading as if nothing
exists yet. app/core/tenancy.py already implements an opt-in
resource_org_id scoping gate, fully tested -- it's accurate that no
real caller activates it yet (the gate is a no-op until a caller
supplies resource_org_id, and none does today), but that's a
narrower gap than "planned" implied. Split the roadmap line into
what's implemented (the gate itself) vs. what's still open
(enforced-by-default multi-tenancy).
- New "Repository Structure" section -- this README had none, despite
meaningful internal layering (core/{rbac,abac,engine,rules,tenancy,
permissions}.py, services/{cache,policy_service}.py, models/).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing numbers were stale, and two real, implemented authorization mechanisms — one of them directly connected to a gateway feature I documented earlier today — weren't described anywhere.
Changes
app/core/permissions.py'sACTION_PERMISSION_MAPis the receiving end ofomnibioai-api-gateway's ownSERVICE_PERMISSION_MAP— a real, active gate checking the requester'spermissionsclaim againstomnibioai-auth's registry strings (workflow.execute,model.use,dataset.read). "Core Features" only described generic RBAC/ABAC before.app/core/tenancy.pyalready implements an opt-inresource_org_idscoping gate, fully tested — it's accurate that no real caller activates it yet, but that's narrower than "planned" implied. Split the roadmap line into what's implemented (the gate) vs. what's still open (enforced-by-default multi-tenancy).Testing
Docs-only change. Verified against a live
pytestrun,app/core/permissions.py, andapp/core/tenancy.pydirectly — not against the prior README text.🤖 Generated with Claude Code