fix: resolve ruff lint findings in Redis ACL safety framework - #20
Merged
Merged
Conversation
PR #19's CI failed on lint (ruff, changed-files-only scope), not on tests -- 86/86 focused tests and 475/475 broader-suite tests passed throughout. All 11 findings were style-only: redundant quotes on type annotations now unnecessary under `from __future__ import annotations`, an unused import left over from an earlier revision, `__enter__`'s return type expressed as `Self`, explicit `check=False` on a subprocess.run whose result is intentionally not checked, and correct noqa codes (S110 + BLE001, not the placeholder BLE001-only comment that shipped) on the two deliberately-silent best-effort cleanup blocks. No behavior change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rufffindings, all style-only — no test or security failures; 86/86 focused tests and 475/475 broader suite passed then and now).from __future__ import annotations), an unused import,__enter__'s return type asSelf, explicitcheck=Falseon a test-helpersubprocess.run, and correctnoqacodes on the two intentionally-silent best-effort cleanup blocks.Test plan
ruff check scripts/redis_acl_safety.py tests/test_redis_acl_safety.py— all checks passedpytest -q tests/test_redis_acl_safety.py— 86 passed, 0 failed🤖 Generated with Claude Code