[devin-ai-integration]

What and why

A FeatureReferenceExpression owns a Membership whose memberElement is the referenced Feature, and referent is derived from it. The writer collapsed the reference to the referent edge and a later pass (materializeReferentMemberships) restated it as a Membership appended after the result parameter and absent from ownedMembership, so ownedRelationship and ownedMembership differed from the pilot on every feature reference expression (api-json differential gap row 43). A FeatureChainExpression's target feature had the same shape.

Now the writer owns the Membership itself, where the notation places it:

• FeatureReferenceExpression: [Membership(referent), ReturnParameterMembership] (featureReferent in rdf_expr.go), with the same ids the restating pass minted (<node>_preferent under an expression node, <element>_referent beside an expression element, claimed against declared ids);
• FeatureChainExpression naming a plain member: [ParameterMembership(operand), Membership(targetFeature), ReturnParameterMembership]; a chained member keeps its OwningMembership of the owned chain feature;
• the Membership an expression owns to the element it names (MetadataAccessExpression's referenced element, an invocation's callee) is listed under ownedMembership as well as ownedRelationship (Namespace::ownedMembership = ownedRelationship->selectByKind(Membership)).

The restating pass is removed; materializeNormative keeps its other work.

Targets develop. The branch was cut on #1328's branch and lands after #1332 in the bridge follow-up order, so #1328's head (97f8c58, which merges develop with #1325) and #1332's head (63cb7b2) are merged in as merge commits, and the baseline and report are re-recorded from the combined tree rather than resolved by picking a side. origin/develop (5db0f74) is merged in as well, with the baseline re-recorded from the merged tree (no scorecard row moved; the writer digest and spec-examples' type-mismatch count moved with develop).

Specification basis

KerML 1.1 Beta 2:

• § 8.2.5.8.3 Base Expressions: FeatureReferenceExpression : ownedRelationship += FeatureReferenceMember, FeatureReferenceMember : Membership = memberElement = FeatureReference; FeatureChainExpression … '.' ownedRelationship += FeatureChainMember, FeatureChainMember : Membership = FeatureReferenceMember | OwnedFeatureChainMember.
• § 8.3.4.8.5 deriveFeatureReferenceExpressionReferent: the referent is the memberElement of the first ownedMembership that is not a ParameterMembership; § 8.3.4.8.4 deriveFeatureChainExpressionTargetFeature likewise for the target feature.
• § 8.4.4.8 Expression semantics: "A FeatureReferenceExpression is parsed with a non-owning Membership relationship to its referent Feature (see 8.2.5.8.3)".

The owned Membership is the abstract-syntax mapping of the notation, not a pilot habit; the pilot agrees. Moves the referent/targetFeature row of docs/project/spec-compliance.md to its new locus (still ✅).

In-flight overlap

• PR feat(export): owned absence and evaluator-derived properties in API JSON #1232 (feature/api-json-derived-properties-layered): touches api_json_*.go only, no rdf_expr.go/rdf_normative.go change and no referent/FeatureReferenceExpression row among its derived properties; no overlap.
• PR feat(identity): fix ids for OpenSysML's own library elements so references link by id #1332 (feat/extension-library-identity): merged in; it changes which references link by id, not the owned Memberships — against its baseline only the rows below move.
• PRs feat(referee): list the api-json matches a run lost and gained, and record why naming-feature keys cost manual-examples 171 #1323, feat(tools): record the API JSON writer's source digest in the differential baseline #1325, feat(referee): load the OpenSysML Libraries into the pilot JSON bridge and re-record the api-json differential #1328: referee and baseline records only; this branch sits on feat(referee): load the OpenSysML Libraries into the pilot JSON bridge and re-record the api-json differential #1328 and re-records its baseline.
• PR-less branch feature/api-json-derived-properties (predecessor of feat(export): owned absence and evaluator-derived properties in API JSON #1232, 9 commits ahead of its merge-base, not in feat(export): owned absence and evaluator-derived properties in API JSON #1232): touches rdf_expr.go for argument/body minting, not the referent Membership. Other PR-less branches touching internal/translate/export (fix/651-…, fix/652-…, fix/653-…, fix/654-…, fix/accept-action-usage, fix/include-use-case-reference-subsetting, fix/send-action-usage) do not touch the referent, target-feature or callee Memberships.

Counter movements (api-json referee, fresh XDG_CACHE_HOME)

Against #1332's baseline (the state this PR lands on): present-equal 619268 → 624752 (+5484), present-different 45688 → 40210 (−5478), ours-missing 1058259 → 1058253 (−6); matched 90023, ours-only, pilot-only, pilot-missing, absent-both and indeterminate unchanged; provenance differs in the api-json-writer source digest and the date only. A fresh-cache -check on the combined tree reproduces the recorded baseline.

Before this PR was combined, the same deltas were measured against #1328's baseline (-check on #1328's then head 3d8d957 in a separate worktree reproduced it exactly): 618674 → 624158, 50027 → 44549, 1058325 → 1058319.

row	before (equal / different / ours-missing)	after	reading
FeatureReferenceExpression.ownedRelationship, .ownedMembership	38 / 2110 / 0	2141 / 7 / 0	the referent Membership now sits before the result and under ownedMembership; the 7 left are a function named as an argument (->reduce '+' in Simple Tests/Expressions.kerml), which the pilot owns as a FeatureMembership of an Expression typed by the function (§ 8.2.5.8.3 FunctionReferenceMember) where ours writes a Membership of the function — a different mapping, recorded in gap row 43
FeatureChainExpression.ownedRelationship, .ownedMembership	0 / 504 / 0	415 / 89 / 0	the target-feature Membership now sits between operand and result; the 89 left are chains the pilot owns as a FeatureChain through an OwningMembership where ours resolves the member to a Membership of the named feature (Control Structures Example.sysml)
InvocationExpression.ownedMembership	0 / 468 / 0	439 / 29 / 0	the callee Membership is an ownedMembership; the 29 left are receiver-first invocations (s.f(x)), where the pilot orders [ParameterMembership, Membership, …] and ours the callee first — the same 29 the ownedRelationship row already carried
ConstructorExpression.ownedMembership	0 / 57 / 0	3 / 54 / 0	the same; the 54 left own a ParameterMembership per argument where the pilot owns none (ActionTest.sysml) — the ownedRelationship row's existing 54
MetadataAccessExpression.ownedMembership	0 / 0 / 6	6 / 0 / 0	the referenced-element Membership is an ownedMembership

Per root, present-equal rises and present-different falls by the same amount (training +563, sysml-examples +1897, sysml-validation +665, kerml-examples +182, spec-examples +145/−144 with one ours-missing closed, tests/testdata +17, examples +1403 with five ours-missing closed, probes +2, manual-examples +610). No other scorecard row moved.

How it was verified

• tests/export goldens: 33 files move. By category: every FeatureReferenceExpression node gains ownedMembership of its referent Membership and lists it before _pout_om (88 nodes), the 11 expression-element feature references (constraint { x }) keep their <element>_referent id and lose the trailing position, FeatureChainExpression/MetadataAccessExpression/invocation nodes list their Membership under ownedMembership (19 nodes reordered); no triple other than ownedRelationship/ownedMembership lists and the moved Membership nodes changes. On the combined tree tests/export and tests/identity pass without further golden movement.
• tests/export/result_expression_test.go TestExpressionBodyParameterIsDeclaredOutsideTheBody pins the new shape; TestReferentMembershipIDCollisionIsRefused pins the id claim at its new locus.
• TestCorpusRoundTrip, TestCorpusAPIJSONRoundTrip, TestSameTriples, TestRefusalClass with OPENSYSML_REQUIRE_TRAINING_CORPUS=1 OPENSYSML_REQUIRE_PILOT_CORPORA=1 OPENSYSML_REQUIRE_SPEC_EXAMPLES=1: pass on the combined tree, no ratchet movement.
• go run -C tools ./cmd/pilot-apijson-diff -update from the combined tree with a fresh XDG_CACHE_HOME, then -check with another fresh cache: reproduces; make docs-counts current.
• On the combined tree: go build ./..., go vet ./..., gofmt -l . (empty), go test ./... (119 packages ok), go test -C tools ./..., make lint, python3 scripts/changelog.py check: pass.

Checklist

• make test and make lint pass locally
• Tests added or updated for the change
• Documentation extended where it already covers the surface (see CONTRIBUTING.md)
• Changelog entry added as changes/unreleased/<slug>.<section>.md, not as an edit to CHANGELOG.md
• baselines regenerated and make docs-counts run if a gate count moved (compliance rows need nothing: the census is counted at docs build)
• No internal work-item labels (waves, slices, F4, K5) in the body, docs, or changelog

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/08dcd1a81c9f4d8881aa21febe894183
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/08dcd1a81c9f4d8881aa21febe894183?variant=devin
Requested by: @HuiJun

[devin-ai-integration]

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

• Disable automatic comment, CI, and merge conflict monitoring

[devin-ai-integration]

Note

Newer findings are available below. Devin Review posted a newer report on this PR, in addition to the findings presented here.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.