Skip to content

refactor(client/java): rename the WITNESS constant and drop an unused import - #1345

Merged
HuiJun merged 1 commit into
developfrom
fix/sonar-client-java
Oct 21, 2026
Merged

HuiJun merged 1 commit into
developfrom
fix/sonar-client-java

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

What and why

Clears the two SonarCloud findings on develop under client/java:

  • java:S1845 (blocker) in opensysml-client/.../CheckResult.java: the constant WITNESS differed from the record component witness only by case; it is WITNESS_NAME, which is what it holds (the component name passed to requireNonNull). The constant is private, so no API changes.
  • java:S1128 in opensysml-conformance/.../Api.java: an unused import of org.openmbee.opensysml.proto.ObservablePair (the code uses CompareOptions.ObservablePair).

No behaviour change, no changelog fragment.

A pull request gets no SonarCloud analysis (the CircleCI scan job runs on develop and main only); the proof that these findings clear is the post-merge scan of develop.

How it was verified

mvn test in client/java passes (232 tests in opensysml-client, with bin/sysml-grpc built so the lifecycle tests run rather than abort); go test ./tests/hygiene passes.

Checklist

  • make test and make lint pass locally
  • Tests added or updated for the change
  • Documentation extended where it already covers the surface (see CONTRIBUTING.md)
  • Changelog entry added as changes/unreleased/<slug>.<section>.md, not as an edit to CHANGELOG.md
  • baselines regenerated and make docs-counts run if a gate count moved (compliance rows need nothing: the census is counted at docs build)
  • No internal work-item labels (waves, slices, F4, K5) in the body, docs, or changelog

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/c2b1ac4ad6de4d8788e78fd86c7c1729
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/c2b1ac4ad6de4d8788e78fd86c7c1729?variant=devin
Requested by: @HuiJun

… import

Co-Authored-By: jason.han <hanhuijun@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@devin-ai-integration
devin-ai-integration Bot marked this pull request as ready for review October 21, 2026 08:41
@HuiJun
HuiJun merged commit 0c588e9 into develop Oct 21, 2026
42 checks passed
@HuiJun
HuiJun deleted the fix/sonar-client-java branch October 21, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant