Skip to content

refactor(client/java): rename the WITNESS constant and drop an unused import #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HuiJun merged 1 commit into from
Oct 21, 2026
Merged

refactor(client/java): rename the WITNESS constant and drop an unused import #1345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions client/java/opensysml-client/src/main/java/org/openmbee/opensysml/CheckResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public record CheckResult(
Standing standing,
String reason) {

private static final String WITNESS = "witness";
private static final String WITNESS_NAME = "witness";

/** Creates a check result; every list is copied. */
public CheckResult {
Expand All @@ -52,7 +52,7 @@ public record CheckResult(
Objects.requireNonNull(claim, "claim");
freeInputs = List.copyOf(freeInputs);
assumptions = List.copyOf(assumptions);
Objects.requireNonNull(witness, WITNESS);
Objects.requireNonNull(witness, WITNESS_NAME);
Objects.requireNonNull(contrast, "contrast");
Objects.requireNonNull(standing, "standing");
Objects.requireNonNull(reason, "reason");
Expand Down Expand Up @@ -120,7 +120,7 @@ public record Violation(
Objects.requireNonNull(kind, "kind");
Objects.requireNonNull(property, "property");
Objects.requireNonNull(error, "error");
Objects.requireNonNull(witness, WITNESS);
Objects.requireNonNull(witness, WITNESS_NAME);
Objects.requireNonNull(text, "text");
}
}
Expand All @@ -135,7 +135,7 @@ public record DivergentValue(String value, Optional<Witness> witness) {
/** Creates a divergent value. */
public DivergentValue {
Objects.requireNonNull(value, "value");
Objects.requireNonNull(witness, WITNESS);
Objects.requireNonNull(witness, WITNESS_NAME);
}
}

Expand Down Expand Up @@ -165,7 +165,7 @@ public record Final(String outcome, Map<String, String> values, Optional<Witness
public Final {
Objects.requireNonNull(outcome, "outcome");
values = Map.copyOf(values);
Objects.requireNonNull(witness, WITNESS);
Objects.requireNonNull(witness, WITNESS_NAME);
}
}

Expand Down
1 change: 0 additions & 1 deletion client/java/opensysml-conformance/src/main/java/org/openmbee/opensysml/conformance/Api.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@
import org.openmbee.opensysml.proto.CompareResultsResponse;
import org.openmbee.opensysml.proto.ImportDataRequest;
import org.openmbee.opensysml.proto.ImportDataResponse;
import org.openmbee.opensysml.proto.ObservablePair;
import java.util.OptionalDouble;
import java.util.OptionalLong;
import org.openmbee.opensysml.proto.CheckBehaviorRequest;
Expand Down
Loading