Repository navigation
owned_window_over: report the owned window's visible frame as region - #1739
Merged
Merged
Conversation
The answer gains region [x, y, w, h]: the owned window's DWM frame bounds (no shadow) in the same click pixels as the query. agnostic-repair uses it to require the cover to span the band from the cut point to the right edge at full height, and asks with a 1x1 region at the dismiss-click point. The backend treats a missing or malformed region as no answer.
Member
Author
|
Independent adversarial review (separate agent, read-only): approve, no blockers. 217 tests pass. What it checked:
Should-fix items, for follow-ups (the freeze rule allows only blocker fixes after approval):
Nits: three docstring lines are over the line length; |
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1735, as the coordinator asked, for agnostic-repair's covered-band repair.
Contract change. The
owned_window_overanswer gainsregion: [x, y, w, h]. It is the reported owned window's visible frame: DWM extended frame bounds, no shadow, in the same click pixels as theregionargument. It is the whole frame, not its overlap with the query, so the caller can require the cover to span the band from the cut point to the right edge at full height.WindowsBackend.owned_window_overnow requires the key and returns None when it is missing or malformed (not 4 ints, a bool, a float, zero or negative size). The caller treats its absence as doubt.1x1 regions. agnostic-repair also asks
owned_window_over((x, y, 1, 1), pinned_step_id=...)at the dismiss-click point and requires the same hwnd as the cover. The existing intersection test already handles a 1x1 box (right and bottom edges exclusive). New tests pin the behaviour:No other behaviour changes: which window is reported, and when the answer is None, are as in #1735. The one in-repo caller,
repair/self_repair.py, readshwndand does not check the key set.Tests: 3 new agent tests, 6 new backend refusal cases, 1 updated expected answer.
test_win_agent_server.py,test_windows_backend.py,test_repair_covered_band.pyandtest_macos_sheets.pypass (237). The macOS sheet backend does not returnregion, so a caller that requires it will treat macOS as doubt until it does.