Skip to content

[com1DFA] Add output hydrograph functions - #1345

Open
JuLa96 wants to merge 1 commit into
masterfrom
JL_AddOutputHydrograph
Open

JuLa96 wants to merge 1 commit into
masterfrom
JL_AddOutputHydrograph

Conversation

@JuLa96

@JuLa96 JuLa96 commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

out1Hydrograph is a module for extracting discharge hydrographs at user-defined
cross sections from debris-flow simulations performed with c1TIF.

It is necessary to add some functions in com1DFA.com1DFA.py and com1DFA.debrisFunctions.py.

This PR is directly related to #17

PR Checklist

Please confirm before requesting review:

  • I ran pytest locally without fails
  • I added/updated tests where needed
  • I updated documentation where needed

Confirm before the final merge/rebase into master

  • Commits are sensibly squashed and rebased onto latest master
  • Standardtest run without difference (with recompiled cython code)

@JuLa96 JuLa96 added enhancement New feature or request DebrisFrame labels Nov 3, 2026
@JuLa96 JuLa96 self-assigned this Nov 3, 2026
@JuLa96
JuLa96 requested review from PaulaSp3, awirb and fso42 November 3, 2026 15:39
@qltysh

qltysh Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

All good ✅

Comment thread avaframe/com1DFA/debrisFunctions.py Resolved
Comment thread avaframe/com1DFA/debrisFunctions.py Resolved
Comment thread avaframe/com1DFA/debrisFunctions.py Resolved
Comment thread avaframe/com1DFA/debrisFunctions.py Resolved
Comment thread avaframe/com1DFA/debrisFunctions.py Resolved
Comment thread avaframe/com1DFA/debrisFunctions.py Resolved
Comment thread avaframe/com1DFA/debrisFunctions.py Resolved
Comment thread avaframe/com1DFA/debrisFunctions.py Resolved
Comment thread avaframe/com1DFA/debrisFunctions.py Resolved
Comment thread avaframe/com1DFA/debrisFunctions.py Resolved
Comment thread avaframe/tests/test_debrisFunctions.py Resolved
Comment thread avaframe/com1DFA/com1DFACfg.ini Resolved
Comment thread avaframe/com1DFA/com1DFACfg.ini Resolved
Comment thread avaframe/com1DFA/debrisFunctions.py Resolved
Comment thread avaframe/com1DFA/debrisFunctions.py Resolved
@JuLa96
JuLa96 requested review from PaulaSp3 and removed request for awirb November 9, 2026 14:06
from com1DFA

adapt workflow in com1DFA.py

add tests for new debris-functions
@JuLa96
JuLa96 force-pushed the JL_AddOutputHydrograph branch from 7d9cf69 to 1a68149 Compare November 9, 2026 16:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DebrisFrame enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants