Skip to content

Add out1Hydrograph module - #117

Merged
JuLa96 merged 1 commit into
masterfrom
JL_OutputHydrograph
Nov 9, 2026
Merged

JuLa96 merged 1 commit into
masterfrom
JL_OutputHydrograph

Conversation

@JuLa96

@JuLa96 JuLa96 commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

out1Hydrograph is a module for extracting discharge hydrographs at user-defined
cross sections from debris-flow simulations performed with c1TIF.

During the simulation, the discharge through each cross section is calculated
from the simulated flow thickness and velocity fields. The results are saved as
time-dependent discharge tables and plotted together with the cumulative flow volume.

closes #88

strongly connected to OpenNHM/AvaFrame#1345

@JuLa96 JuLa96 added the enhancement New feature or request label Nov 3, 2026
@JuLa96 JuLa96 self-assigned this Nov 3, 2026
@JuLa96
JuLa96 requested review from PaulaSp3 and fso42 November 3, 2026 09:10
@qltysh

qltysh Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

All good ✅

Comment thread debrisframe/in2TopoHyd/in2TopoHyd.py Resolved
Comment thread debrisframe/in2TopoHyd/in2TopoHyd.py Resolved
Comment thread debrisframe/in2TopoHyd/in2TopoHyd.py Resolved
Comment thread debrisframe/outHelper/out1HelpDFHyd.py Resolved
@JuLa96

JuLa96 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

A separate commit will be added for function tests

@JuLa96

JuLa96 commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor Author

The failing test is related to the function avaframe/in1Data/getInput.getAndCheckInputFiles. This function was updated recently (Version 2.2b1) and it seems that the test uses an older version of the function.

Comment thread debrisframe/tests/test_out1HelpDFHyd.py Resolved
@JuLa96
JuLa96 force-pushed the JL_OutputHydrograph branch from 6fdebe5 to cdd08fe Compare November 4, 2026 13:43
@qltysh

qltysh Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
debrisframe/tests/test_c1TIF.py100.0%
New file Coverage rating: A
debrisframe/tests/test_out1HelpDFHyd.py100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@fso42 fso42 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slideTopo.asc and the slideRelease shapefile are deleted, and DEM_ParabolaChanneled.asc is added. Is this wanted?

Comment thread debrisframe/in2TopoHyd/in2TopoHyd.py Resolved
Comment thread debrisframe/in2TopoHyd/in2TopoHyd.py Resolved
Comment thread debrisframe/in2TopoHyd/in2TopoHyd.py Resolved
Comment thread debrisframe/c1TIF/c1TIFCfg.ini Resolved
Comment thread debrisframe/runOut1Hydrograph.py Resolved
Comment thread debrisframe/runOut1Hydrograph.py Resolved
Comment thread debrisframe/runOut1Hydrograph.py Resolved
Comment thread debrisframe/runOut1Hydrograph.py Resolved
Comment thread debrisframe/in2TopoHyd/in2TopoHyd.py Resolved
Comment thread debrisframe/outHelper/out1HelpDFHyd.py Resolved
Comment thread debrisframe/in2TopoHyd/in2TopoHyd.py Resolved
Comment thread debrisframe/in2TopoHyd/in2TopoHyd.py Resolved
Comment thread debrisframe/in2TopoHyd/in2TopoHyd.py Resolved
Comment thread debrisframe/in2TopoHyd/in2TopoHyd.py Resolved
Comment thread debrisframe/runOut1Hydrograph.py Resolved
Comment thread debrisframe/runOut1Hydrograph.py Resolved
Comment thread debrisframe/c1TIF/c1TIF.py Resolved
Comment thread debrisframe/outHelper/out1HelpDFHyd.py Resolved
Comment thread debrisframe/tests/test_out1HelpDFHyd.py Resolved
@JuLa96
JuLa96 requested a review from PaulaSp3 November 9, 2026 11:52
Comment thread debrisframe/in2TopoHyd/in2TopoHyd.py Resolved
Comment thread debrisframe/in2TopoHyd/in2TopoHyd.py Resolved
@JuLa96
JuLa96 force-pushed the JL_OutputHydrograph branch from e153002 to 8fad620 Compare November 9, 2026 16:42
add pytests

add docu

fix test_c1TIF.py

adapt in2TopoHyd.py
@JuLa96
JuLa96 force-pushed the JL_OutputHydrograph branch from 8fad620 to 7d8af85 Compare November 9, 2026 16:44
@JuLa96
JuLa96 merged commit 9ffd36e into master Nov 9, 2026
4 checks passed
@JuLa96
JuLa96 deleted the JL_OutputHydrograph branch November 9, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

implement output hydrograph (result)

3 participants