Repository navigation
Conversation
Resolve the template through the existing view-data path lookup and offer its input names instead of the variadic params container. Navigate labels to their first source reads and show the template's normal PHP hover type. Read only the selected template, using indexed variable bindings and source maps to distinguish incoming data from locals and isolated scopes. Cover spreads, imports, captures, conditional bindings, incomplete calls, unsaved edits, stale metadata, and calls made from templates.
Add a title input to the view playground and verify named data reaches both populated and empty views with Tempest's renderer. Document completion, navigation, and hover, credit the contribution, and remove the completed roadmap item while preserving release and sprint markers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
shuvroroy
marked this pull request as ready for review
November 9, 2026 05:30
Closed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Named data passed to Tempest's
view()now completes from the receiving template's inputs. A label such asbooks:jumps to the template's first read of$booksand shows its normal PHP type in a View parameter hover.The lookup reverses the path resolution already used for view-data inference and reads only the selected template. It excludes data already supplied by the call, local bindings, and isolated scopes, while preserving closure captures, conditional bindings, unsaved edits, and template source coordinates. Custom View constructors keep their ordinary parameter handling.
This is the separate follow-up to #560; its branch starts from
mainand contains only view-argument changes.Validation:
cargo testsuite passes.cargo clippy --fix --allow-dirty -- -D warnings, thencargo fmt, andcargo clippy --all-targets -- -D warningspass.Checklist: