Migrate to Parcels v4 - #342
Conversation
…ument column entries are consistent
for more information, see https://pre-commit.ci
f474279 to
0fe1340
Compare
|
This PR is ready for re-review. Please note a couple of things, which have been added more recently, including tinkering around Also, there are some changes that have been reviewed already, most notably the updates to the docs, and probably don’t need much time spent on them. Apologies this probably wasn’t the most efficient way of structuring the PRs. |
erikvansebille
left a comment
There was a problem hiding this comment.
Impressive effort, @j-atkins! See below some small comments/questions
…ate tests with more tolerance for interpolation discrepancies
|
Thanks for the review, @erikvansebille! Comments now addressed, including moving to using boolean indexing across all (non-underway) instrument kernels. @VeckoTheGecko I have updated/unpinned pixi in the |
Heya - just seeing this. Will take a look at the |
|
The |
erikvansebille
left a comment
There was a problem hiding this comment.
Looks good - happy for you to merge!
This PR migrates to using Parcels v4 for VirtualShip.
Argo float bug [in kernel(s)?], immediately goes out of bounds after first timestep... likely depth convention related--from-data.zarroutput) [new PR]positive: downorpositive: upARGO_FLOATS: Enhance performance + no need to updatecycle_ageduring ascent?Closes #239, closes #232, closes #231, closes #323, closes #238