Skip to content

fix: drop SCOPED_TRACE that crashes the pixi Windows job #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dv-picknik wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: drop SCOPED_TRACE that crashes the pixi Windows job #33

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eac4a51
test: drop SCOPED_TRACE from MissingOrEmptyGenericChildIdIsRejected
dv-picknik Sep 25, 2026
e87cb6c
ci: run push workflows on main
dv-picknik Sep 25, 2026
9b1e3b3
Revert "ci: run push workflows on main"
dv-picknik Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/gtest_reactive.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,14 +297,13 @@ TEST(Reactive, MissingOrEmptyGenericChildIdIsRejected)
// GIVEN generic child tags without a usable registered ID.
for(const char* child : { "<Action/>", R"(<Action ID=""/>)" })
{
SCOPED_TRACE(child);
BT::BehaviorTreeFactory factory;
const std::string xml = std::string(R"(<root BTCPP_format="4"><BehaviorTree ID="Test">
<ReactiveSequence>)") +
child + "</ReactiveSequence></BehaviorTree></root>";

// WHEN registering the malformed tree.
// THEN the generic tag cannot stand in for a registered Behavior.
EXPECT_THROW(factory.registerBehaviorTreeFromText(xml), BT::RuntimeError);
EXPECT_THROW(factory.registerBehaviorTreeFromText(xml), BT::RuntimeError) << child;
}
}
Loading