fix: drop SCOPED_TRACE that crashes the pixi Windows job

[dv-picknik]

[written by AI]

pixi_conda_build (windows-latest) has failed on every PR since #30. Reactive.MissingOrEmptyGenericChildIdIsRejected crashes with SEH 0xc0000005. It's the only test in the suite that uses SCOPED_TRACE, and the new SCOPED_TRACE test in #32 crashed the same way. #32 drops it too. The cmake Windows job passes the same tests. It builds gtest from source through conan, while pixi links conda-forge's prebuilt gtest DLL, so I think the prebuilt DLL is the trigger. I have no Windows machine to confirm the mechanism. This PR's own pixi Windows run passes, the first green one since #30.

This PR streams the child tag into EXPECT_THROW instead of using SCOPED_TRACE, so a failure still names the case. The push-trigger fix that was here moved to #34, because workflow changes trip CodeRabbit's Human Review Check.

On Linux all 216 tests pass. PickNikRobotics/moveit_pro#21028 and #28 fixed an earlier Windows failure, a toolset mismatch that broke the build before any test ran.

🤖 Generated with Claude Code

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 7f9c5675-e3a7-461f-be49-eee84bcc65dc

📥 Commits

Reviewing files that changed from the base of the PR and between f218093 and e87cb6c.

📒 Files selected for processing (7)

• .github/workflows/cmake_ubuntu.yml
• .github/workflows/cmake_windows.yml
• .github/workflows/pixi.yaml
• .github/workflows/pre-commit.yaml
• .github/workflows/ros2-rolling.yaml
• .github/workflows/ros2.yaml
• tests/gtest_reactive.cpp

Included review availability: This review used your included allowance. 7 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.

---

📝 Summary

Summary by CodeRabbit

• Chores
  • Automated build and validation workflows now run on pushes to main.
• Tests
  • Failure output for the missing-or-empty child ID test now includes the tested XML.

Walkthrough

Six GitHub Actions workflows now run on pushes to main. A reactive test includes the tested child XML in its failure output and no longer uses a per-iteration SCOPED_TRACE.

Changes

Workflow Push Triggers

Layer / File(s)	Summary
Update workflow push branches .github/workflows/cmake_ubuntu.yml, .github/workflows/cmake_windows.yml, .github/workflows/pixi.yaml, .github/workflows/pre-commit.yaml, .github/workflows/ros2-rolling.yaml, .github/workflows/ros2.yaml	The push branch filter changes from master to main in all six workflows. Pull-request triggers and build steps remain unchanged.

Reactive Test Failure Output

Layer / File(s)	Summary
Include child XML in failure output tests/gtest_reactive.cpp	The test retains its BT::RuntimeError expectation, adds the child XML to failure output, and removes the per-iteration SCOPED_TRACE.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 9b1e3

The workflow and test changes match their stated intent; no merge-blocking behavior change is evident.

---

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

• Ignore (reviewers only)

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Human Review Check	❌ Error	The PR changes six GitHub Actions workflows from push triggers on master to main. The repository has a main branch, so this activates CMake Ubuntu, CMake Windows, Pixi, pre-commit, ROS 2, and RO…	This PR requires review by a requested human reviewer. After review, a non-author requested reviewer should override this pre-merge check.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The pull request description clearly explains the test change, the Windows failure, the suspected cause, the workflow-trigger scope, and the reported test results. The repository template contains onl…

Full details: Human Review Check

Explanation

The PR changes six GitHub Actions workflows from push triggers on master to main. The repository has a main branch, so this activates CMake Ubuntu, CMake Windows, Pixi, pre-commit, ROS 2, and ROS 2 Rolling jobs on pushes to main; several jobs use runner matrices, and the Ubuntu job also uploads coverage. This is CI/CD configuration that can increase runner usage and costs. The test change is low risk, but the workflow changes meet the failure condition.

• Fix all pre-merge checks with AI

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Pre-merge checks failed. Please resolve the failing checks before merging.