Skip to content

ci: run push workflows on main - #34

Open
dv-picknik wants to merge 1 commit into
mainfrom
ci/push-workflows-on-main
Open

dv-picknik wants to merge 1 commit into
mainfrom
ci/push-workflows-on-main

Conversation

@dv-picknik

Copy link
Copy Markdown
Member

[written by AI]

Point the push triggers of six workflows at main. They named master, which in this fork mirrors upstream, while PRs merge to main, the default branch. So no workflow runs on merge to main. That's how the pixi Windows crash from #30 went unnoticed there. #33 fixes the crash.

doxygen-gh-pages.yml already lists main and is unchanged. Note that cmake_ubuntu.yml will also upload coverage to Codecov on every push to main, and every job here runs once more per merge. pixi.yaml has CRLF line endings, which the edit keeps.

This was part of #33. CodeRabbit's Human Review Check fails any workflow change until a requested human reviewer overrides it, so this PR needs that override.

🤖 Generated with Claude Code

The push triggers name master, which here mirrors upstream, while PRs merge to main, the default branch. No workflow runs on merge to main, so the pixi Windows crash introduced by #30 never showed there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 0277762b-1bc6-4b56-9335-490e887258f8

📥 Commits

Reviewing files that changed from the base of the PR and between f218093 and 77f1b1a.

📒 Files selected for processing (6)
  • .github/workflows/cmake_ubuntu.yml
  • .github/workflows/cmake_windows.yml
  • .github/workflows/pixi.yaml
  • .github/workflows/pre-commit.yaml
  • .github/workflows/ros2-rolling.yaml
  • .github/workflows/ros2.yaml

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 6 reviews per hour.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated automated build and validation checks to run on pushes to the main branch. Pull-request triggers and existing build steps remain unchanged.

Walkthrough

Six GitHub Actions workflows now run on pushes to main instead of master. Their pull-request triggers and build steps are unchanged.

Changes

Workflow push triggers

Layer / File(s) Summary
Update workflow push branch filters
.github/workflows/*
Six workflows now use main instead of master as the push trigger branch. Pull-request triggers and build steps are unchanged.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to 77f1b

This change directs the six workflows to run on pushes to main while leaving pull-request triggers unchanged. No concrete merge risk remains.


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore (reviewers only)

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Human Review Check ❌ Error The PR changes six GitHub Actions workflows, so it is a CI/CD change. Each workflow changes its push trigger from master to main. This enables hosted-runner jobs on pushes to main, including Win… This PR requires review by a requested human reviewer. After review, a non-author requested reviewer should override this pre-merge check.
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the workflow changes, affected files, motivation, effects, preserved line endings, and review requirement. The repository template contains only informati…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Human Review Check

Explanation

The PR changes six GitHub Actions workflows, so it is a CI/CD change. Each workflow changes its push trigger from master to main. This enables hosted-runner jobs on pushes to main, including Windows, Ubuntu, Pixi, pre-commit, ROS 2 matrix jobs, and a Codecov upload. The change can increase runner usage and costs on merges to main.

  • Fix all pre-merge checks with AI

Comment @coderabbitai help to get the list of available commands.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-merge checks failed. Please resolve the failing checks before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant