[lorenzocorallo]

Summary

• Expose registered IdP users to the backend through a service-token-protected endpoint.
• Return user ID, name, and email, including people who have never opened Signatures.
• Keep signer permission and drive-rule decisions in the backend's access snapshot.

Verification

• pnpm exec tsc --noEmit
• pnpm exec vp test (305 passed, 115 skipped)
• pnpm exec vp check src/auth/access-snapshot.integration.test.ts src/routes/api/internal/esign-users.ts
• pnpm run build

Rollout

Deploy before the backend signer-directory change. The new endpoint's HTTP integration test needs the configured integration database and URL to run.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 8a0e91b9-065d-4e31-883b-12c3fb78b312

📥 Commits

Reviewing files that changed from the base of the PR and between dddb4ec and 74c844c.

📒 Files selected for processing: 4

• src/auth/access-snapshot.integration.test.ts
• src/dev/personas.ts
• src/routeTree.gen.ts
• src/routes/api/internal/esign-users.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The pull request adds a protected /api/internal/esign-users endpoint, registers it in the route tree, and adds integration coverage. It also changes the formatting of the empty DevFixtureConflict class without changing its behavior.

Changes

E-sign user endpoint

Layer / File(s)	Summary
Endpoint authorization and response src/routes/api/internal/esign-users.ts	The GET handler checks backend OAuth configuration and client projection. It returns user IDs, names, and emails ordered by name and ID, with private no-store caching and Vary: Authorization.
Route registration and integration coverage src/routeTree.gen.ts, src/auth/access-snapshot.integration.test.ts	The generated route tree includes /api/internal/esign-users. The integration test checks unauthenticated and wrong-scope responses, then verifies a valid token response and its cache header.
Empty class formatting src/dev/personas.ts	The empty DevFixtureConflict class formatting changes. Its behavior remains unchanged.

Priority: ➖ Normal

Change: Feature

Merge Risk: ⚪ Minimal · up to 74c84

The endpoint is ready to merge after normal checks.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: exposing registered users to the signing backend through the new protected endpoint.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}