Repository navigation
Conversation
a8d0b0b to
89368dc
Compare
108290a to
e70d955
Compare
89368dc to
a66b990
Compare
|
Parent-gated build hand-off. Head remains Tests for this child: 0 executed in this job; no claim is made about the current head's CI. Preserve Anthony's corrected disabled-worker earnings-disregard regression (£1,929.20) when updating the base. Draft status unchanged; no merge/readiness/closure action. Once #2225 lands, the pending commands are: git fetch origin main add-hb-permitted-work
git switch add-hb-permitted-work # create tracking branch if absent
git merge --no-ff origin/main
# Resolve, run focused foreground tests with -n 2 after load1 <=110 and
# os.statvfs available disk >=55 GB decimal; commit fixes and push once.
gh api -X PATCH repos/PolicyEngine/policyengine-uk/pulls/2219 -f base=mainOpen items: parent landing; merge/test/push/body refresh as needed; retarget; hub independent review. #2229 remains gated on this PR's landing. |
juaristi22
left a comment
There was a problem hiding this comment.
Reviewed at a66b990b52a468d2182d3154cbcbf8da66982b1a, limited to the permitted-work change over its stacked parent. No actionable findings from independent policy/source and code reviews.
The component replaces the selected ordinary disregard, preserves a higher lone-parent amount and caps the result at earnings. Its external pre-assessment contract matches the GB working-age rule and corresponding GB pension-age/NI provisions. It does not infer qualifying work or partner allocation from generic flags.
Validation:39 focused tests passed. An eligible claimed-HB integration raises the final award from£6477.90 to£10208.90 when the external£6000 assessment is supplied, exactly65% of the£5740 replacement difference; passport and cap effects were excluded. The documented upstream-assessment coverage limitation and stacked-parent merge order remain.
Fixes #2218
Adds the approved pre-assessed annual Housing Benefit permitted-work disregard. The supplied amount replaces the ordinary earnings disregard, retains a higher lone-parent amount, is capped at net earnings, and leaves the additional and accommodation disregards separately conditional. The statutory earnings, work and partner-allocation limits are assessed externally, not inferred from gross work income.
Government sources embedded in code: GB working-age Schedule 4 paragraph 10A, GB pension-age paragraph 5A, and the matching NI working-age and pension-age provisions.
Approved plan C6 only: four files, one GBP input. No dataset mapping has been verified. Missing/zero input preserves the ordinary-disregard approximation and can understate qualifying awards; public variable documentation explains this. No new ESA or permitted-work eligibility engine.
Validation: 32 new YAML cases passed in the existing core 3.32.13 environment. Covers GB/NI and both regulation sets, replacement, lone-parent precedence, low earnings, additional-disregard equality and failure, accommodation, parameter reform, passport, and replacement of the special standard amount. The six special-disregard tests also pass on the composed branch.
make formatandgit diff --checkpassed. No full suite, population simulation or CI polling.Merge dependency: stacked on #2225 (special standard disregard); merge #2225 first, then this PR. The childcare and first-year accommodation changes follow this replacement.
axiom: TheAxiomFoundation/rulespec-uk#375 queued
The special and permitted-work earnings disregards extension to rulespec-uk#375, with the law, required outputs and companion tests: TheAxiomFoundation/rulespec-uk#375 (comment) (UK hub, 24 Oct).