Repository navigation
Conversation
This was referenced Oct 8, 2026
Contributor
Author
|
Replaced by #566 on fix/560-temporary-acs-wic-compatibility. The replacement contains only the immediate temporary WIC compatibility fix, its focused tests, and removal instructions. The source partition/state-year preparation prototype is excluded and preserved separately on its existing branch; it must not ship with this fix. The removal follow-up #563 is being restacked on the clean compatibility branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #560
The separate removal draft is #563. It is blocked on the replacement dataset
tracked in PolicyEngine/microcosm#1154.
Changes
acs_2024_1yrwithTrue, preserving donor and existing ACS decisions. Country-model eligibility remains unchanged.Temporary assumption and follow-up
Replacement dataset publication and compatibility removal are tracked by PolicyEngine/microcosm#1154. The Microcosm code repair is PolicyEngine/microcosm#1156; rebuild/publication is performed by a separate dataset owner. The separate stacked removal draft #563 fixes #561 and must not merge before the actual replacement is published and certified. Ordinary old-name mapping remains while other certified datasets require it.
Validation
uv run --no-sync pytest tests/test_us_legacy_inputs.py tests/test_us_legacy_inputs_integration.py -q: 87 passed.uv run --no-sync pytest tests/test_us_state_year_preparation.py -q: 12 passed, including complete and missing-ACS source fixtures.No full executor suite, real dataset rebuild/publication, paid compute, deployment, new environment variable, or database change.