Update pgtle tests for PGXNTOOL_PGTLE_VERSION rename - #64
Merged
jnasbyupgrade merged 1 commit intoJul 31, 2026
Merged
Conversation
Add tests/updates for pgxntool commit 092f5c0 (rename PGTLE_VERSION to PGXNTOOL_PGTLE_VERSION): - base.mk's pgtle target now reads PGXNTOOL_PGTLE_VERSION instead of PGTLE_VERSION, avoiding a silent collision with same-named environment variables (issue #78) - Updated test/sequential/04-pgtle.bats to invoke `make pgtle PGXNTOOL_PGTLE_VERSION=...` instead of the old variable name - Added a regression test confirming that setting a PGTLE_VERSION environment variable no longer has any effect on `make pgtle` Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jnasbyupgrade
marked this pull request as ready for review
July 31, 2026 20:58
jnasbyupgrade
added a commit
to Postgres-Extensions/pgxntool
that referenced
this pull request
Jul 31, 2026
Fixes #78. Companion pgxntool-test PR: Postgres-Extensions/pgxntool-test#64 Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PGTLE_VERSIONtoPGXNTOOL_PGTLE_VERSION(issue pgxntool#78) to avoid a silent collision with same-named CI environment variables.test/sequential/04-pgtle.batsto invokemake pgtle PGXNTOOL_PGTLE_VERSION=...instead of the old variable name.PGTLE_VERSIONenvironment variable no longer has any effect onmake pgtle(reproduces the issue #78 scenario).