Rename PGTLE_VERSION to PGXNTOOL_PGTLE_VERSION - #85
Merged
jnasbyupgrade merged 1 commit intoJul 31, 2026
Merged
Conversation
make auto-imports environment variables of the same name as an unset make variable, and `pgtle`'s version-limiting variable was named PGTLE_VERSION -- also a natural name for a CI job's "which pg_tle to test against" env var. When such an env var was set, `make pgtle`/`make run-pgtle` silently generated/ran the wrong version-range directory instead of erroring. Renamed to PGXNTOOL_PGTLE_VERSION to avoid the collision. Updated README.asc/README.html, CLAUDE.md, and HISTORY.asc accordingly. Related changes in pgxntool-test: - test/sequential/04-pgtle.bats updated to use PGXNTOOL_PGTLE_VERSION - Added a regression test confirming a PGTLE_VERSION env var no longer affects `make pgtle` Fixes Postgres-Extensions#78. Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jnasbyupgrade
marked this pull request as ready for review
July 31, 2026 20:59
jnasbyupgrade
added a commit
to Postgres-Extensions/pgxntool-test
that referenced
this pull request
Jul 31, 2026
- Companion test for Postgres-Extensions/pgxntool#85, which renames `PGTLE_VERSION` to `PGXNTOOL_PGTLE_VERSION` (issue pgxntool#78) to avoid a silent collision with same-named CI environment variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base.mk'spgtletarget read a make variable namedPGTLE_VERSIONto limit generation to one version range. Make auto-imports environment variables of the same name into unset make variables, andPGTLE_VERSIONis also a natural name for a CI job's "which pg_tle to test against" env var — when one was set,make pgtle/make run-pgtlesilently misbehaved instead of erroring.PGXNTOOL_PGTLE_VERSIONto avoid the collision.README.asc/README.html,CLAUDE.md, and added aSTABLEHISTORY.ascentry.Fixes #78.
Companion pgxntool-test PR: Postgres-Extensions/pgxntool-test#64