fix(types): validate post-ASAP DAG wire contracts - #373
Merged
Conversation
zzylol
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The post-ASAP DAG is exchanged across a process boundary, but its previous wire shape could represent contradictory nodes, dangling edges, duplicate IDs, cycles, and edge metadata that disagreed with its producer. It also had no version marker for evolving the contract.
This adds a strict, versioned
PostAsapDagDocumenttransport envelope and validates the complete graph before a consumer accepts it. The existing bareExecutableDagserialization remains available as an explicit compatibility adapter. Compilation now validates its own output, and the validator checks operator/payload agreement, node and endpoint identity, reachability, acyclicity, and duplicated edge schema/data-state invariants.Validation:
cargo test -p asap-types post_asap::executable_dag