fix(types): enforce post-ASAP summary consistency - #374
Merged
Conversation
zzylol
changed the title
zzylol
changed the base branch from
fix/post-asap-dag-wire-contract
to
main
September 10, 2026 14:02
zzylol
force-pushed
the
fix/post-asap-semantic-consistency
branch
from
September 10, 2026 14:02
0abceea to
b6db64a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A validated post-ASAP graph could still declare one grouping layout on
SummaryAgg, encode another layout in its sketch state schema, or declare an output family absent from that schema. CandidateTopK also transportedkas architecture-dependentusize.This extends graph validation to enforce one family and grouping meaning at the summary boundary and changes the transport payload's TopK count to fixed-width
u64. It retains the existing semantic IR's localusize; compilation is the explicit adapter into the portable wire representation.Stacked on #373.
Validation:
cargo test -p asap-types