refactor(types): reuse canonical lifecycle wire types - #375
Merged
Conversation
zzylol
force-pushed
the
refactor/canonical-lifecycle-wire
branch
from
September 10, 2026 14:01
f146b57 to
7d114d8
Compare
zzylol
force-pushed
the
fix/post-asap-semantic-consistency
branch
from
September 10, 2026 14:02
0abceea to
b6db64a
Compare
zzylol
force-pushed
the
refactor/canonical-lifecycle-wire
branch
from
September 10, 2026 14:02
7d114d8 to
a348a12
Compare
zzylol
changed the base branch from
fix/post-asap-semantic-consistency
to
main
September 10, 2026 15:57
zzylol
force-pushed
the
refactor/canonical-lifecycle-wire
branch
from
September 10, 2026 15:57
a348a12 to
4a666cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lifecycle exports maintained parallel copies of the canonical lifecycle, mode, schedule, representation, and rejection enums. Adding a variant required editing both vocabularies and their manual mapping, which allowed the planner and exported contract to drift.
This makes the canonical lifecycle types serializable with the established wire names and reuses them directly in the DAG export. The JSON shape remains stable, while the duplicate export enums and conversion functions are removed.
Stacked on #374.
Validation:
cargo test -p asap-aware-mapping summary_maintenance