Repository navigation
v1 CLARIOstar: basic luminescence through the emission monochromator - #1525
Merged
Merged
Conversation
BioCam
force-pushed
the
bmg-clariostar-v1-luminescence
branch
7 times, most recently
from
October 22, 2026 06:25
6a5e771 to
4419b2e
Compare
BioCam
marked this pull request as ready for review
October 22, 2026 08:28
BioCam
force-pushed
the
bmg-clariostar-v1-luminescence
branch
from
October 22, 2026 08:30
4419b2e to
31dc2c2
Compare
- `Luminescence.measure` reads the plate's luminescence from the top, each well at its centre, with enhanced dynamic range, through one emission band of the monochromator. - The emission band, gain, focal height, normalization time, measurement interval, settling, reading direction, corner and shaking are sent. - The emission limit follows the photomultipliers: up to 840 nm with the extended-red one on the luminescence path, 740 nm without. - `pylabrobot.lib.luminescence.LuminescenceResult`; `CLARIOstarLuminescenceResult` adds the gain. - `driver.luminescence` and `CLARIOstarDevice.luminescence` exist when the reader reports a luminescence channel. - `FluorescenceConfiguration.maximum_chromatics` is renamed `maximum_fluorescence_channels`. - Comments, docstrings and test names reworded, nothing changes on the wire; the test data files are renamed `*_ground_truth.json.gz`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BioCam
force-pushed
the
bmg-clariostar-v1-luminescence
branch
from
October 22, 2026 09:37
31dc2c2 to
262b2d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
The v1 CLARIOstar reads absorbance and fluorescence, but not luminescence, although the reader reports a luminescence measurement channel. Luminescence assays (luciferase reporters, ATP viability, BRET) cannot run on it through PyLabRobot.
PR Content
Luminescence.measure: a point read of each well from the top, with enhanced dynamic range, through one emission band of the emission monochromator.emission_wavelength/emission_bandwidth(580 / 80 nm),gain(3500),focal_height(None: a quarter up the well, as for fluorescence),normalization_time(1.00 s),measurement_interval(0.80 s), plusMeasurementSettings(settling, corner, reading direction) andShakeSettingsas the other modes take them.pylabrobot.lib.luminescence.LuminescenceResult, the same for every plate reader;CLARIOstarLuminescenceResultadds the gain.driver.luminescence/CLARIOstarDevice.luminescence, built at setup only when the reader reports a luminescence channel.FluorescenceConfiguration.maximum_chromaticsis renamedmaximum_fluorescence_channels.*_ground_truth.json.gz.measurewarns that luminescence is untested.🤖 Generated with Claude Code