fix(sessions): drop the u64 identity conversion clippy rejects - #1858
Merged
Merged
Conversation
CI clippy (rust 1.97, -D warnings) fails master since #1857: useless_conversion on the JSONL partial-window test's file length, which is already u64. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 19, 2026
ScriptedAlchemy
added a commit
that referenced
this pull request
Sep 19, 2026
ScriptedAlchemy
added a commit
that referenced
this pull request
Sep 19, 2026
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI clippy (rust 1.97,
-D warnings) rejects master since #1857 merged without a CI run:useless_conversionon the JSONL partial-window test, which wraps an already-u64file length inu64::try_from.This drops the conversion. One line, test code only.
Verified:
cargo clippy -p tracedecay-sessions --all-targets --locked -- -D warningspasses on this commit and fails on master atjsonl_observation_admission/tests.rs:1029.Batch C (#1848) carries the same commit so its next run is not red on this lint.
🤖 Generated with Claude Code