test(code-index): fence the busy follow-up expired-proof read - #1868
Merged
Merged
Conversation
The test held the admission permit and the owner pass guard while it aged the source proof, but the graph tail renews the proof after both read idle, so the read could observe a fresh proof and the abstain assertion failed. Hold the scheduler mutex across the aging and the read, the fence #1867 introduced for the same window. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
graph_read_during_reconcile_records_a_busy_follow_uphas the same unfenced arrangement #1867 fixed in its sibling. It holds the admission permit and the owner pass guard, ages the source proof, and reads it back expecting the read to abstain. The graph tail's renewing steps run after both of those signals read idle, so under load the read can see a renewed proof and the abstain assertion fails atreconcile.rs:2593.The test now holds the scheduler mutex across the aging and the read through
hold_scheduler_for_root, which #1867 added. Production code is unchanged.A review lane reproduced the failure once in eight whole-module runs under CPU contention on unmodified master (two spinners and the module pinned to the same two cores). The same recipe on this box gave 0 failures in 12 pre-fix module runs and 0 in 8 post-fix runs, so the local rate is too low to show a before-versus-after delta. The fix rests on the mechanism, which #1867 traced with backtraces at the freshness mutators, and on the lane's captured failure at this exact assertion.
The two tests the lane was asked about,
reopened_current_text_generation_resolves_publication_identity_without_graph_seatandresident_memory_graph_refusal_seats_text_serving_without_graph, did not reproduce in 40 attempts each under four contention shapes and are not changed.🤖 Generated with Claude Code