test(runtime-core): keep git auto-maintenance out of the fixture - #1869
Merged
Merged
Conversation
Git 2.47+ detaches maintenance after a commit and holds .git/objects/maintenance.lock while it runs. The authority tests snapshot the git dir before and after their reads to prove the authority writes nothing, and the lock file landed in the before snapshot and vanished before the after one, so the comparison failed on a CI runner with git 2.55. The application crate fixture already disables maintenance.auto and gc.auto for the same reason. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
authority_reports_sha256_identity_head_and_refsfailed on PR #1868's run 35471234177 atgit_repository_authority.rs:189. The test snapshots the git dir before and after the authority's reads to prove the authority writes nothing. The junit diff shows the before snapshot held.git/objects/maintenance.lockand the after snapshot did not.Git 2.47 and later detach
maintenance run --autoafter a commit, and the detached process holds that lock for a moment. The CI runner has git 2.55, so the fixture's own commit raced the snapshot. The authority did not write anything.The fixture now passes
maintenance.auto=falseandgc.auto=0to every git call, includingfast-import. The application crate's git fixture already does this for the same reason. Local git here is 2.43, which does not detach maintenance, so the file's 14 tests passing locally only shows nothing regressed. The CI run on this branch is the real check.🤖 Generated with Claude Code