test(sessions): keep git auto-maintenance out of the fixture - #1885
ScriptedAlchemy wants to merge 1 commit into
Conversation
Git 2.47+ detaches maintenance after a commit and holds .git/objects/maintenance.lock while it runs. The read-only capture test fingerprints the git dir before and after two captures, so a lock that appears in the first snapshot and is gone by the second reads as the capture having touched the object store. The fixture now disables auto maintenance and gc for every git call, as the runtime-core fixture does. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Folded into #1886 as its second commit so one CI cycle covers both test-fixture fixes; this branch's own base was the broken master head. |
1 participant
provenance_capture_copies_no_git_objectswent red on PR #1877's run (FLKY-FL 2/2 in the core-storage partition) with.git/objects/maintenance.lockpresent in the before fingerprint and absent in the after one. Git 2.47+ detachesmaintenance run --autoafter a commit and holds that lock while it runs, so the fixture's own commit, not the capture, moved the object store. This is the mechanism #1869 fixed for the runtime-core fixture; the sessions fixture now disables auto maintenance and gc for every git call the same way.The 20 provenance tests pass locally and the crate's clippy is clean.
🤖 Generated with Claude Code