test(query): build the census token kind as a Cow - #1886
Merged
Merged
Conversation
#1881 changed ConservativeCloneTokenV1::syntax_kind to Cow<'static, str> and #1882 added a census test that builds it from a String. Each was green on its own branch; master's push run after each merge was cancelled by the next merge, so the union first compiled on master and failed the clippy, feature-gates and core-storage jobs with E0308. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Git 2.47+ detaches maintenance after a commit and holds .git/objects/maintenance.lock while it runs. The read-only capture test fingerprints the git dir before and after two captures, so a lock that appears in the first snapshot and is gone by the second reads as the capture having touched the object store. The fixture now disables auto maintenance and gc for every git call, as the runtime-core fixture does. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master's push run at d508196 fails to compile the query crate's lib tests: #1881 made
ConservativeCloneTokenV1::syntax_kindaCow<'static, str>and #1882 added a census test that builds it from aString. Each PR was green on its own branch. Master's push run after each merge was cancelled by the following merge under the workflow's concurrency group, so the union was never compiled before it landed.One-line fix: the test builds the kind with
.into(). The second commit is #1885 folded here: the sessions git fixture disables auto maintenance and gc soprovenance_capture_copies_no_git_objectsstops seeing.git/objects/maintenance.lockin its before fingerprint, the mechanism #1869 fixed for the runtime-core fixture. The query crate's census tests and its clippy under-D warningspass locally.🤖 Generated with Claude Code