Repository navigation
Skip capture-side boost controls in ALSA volume detection - #310
Merged
Merged
Conversation
Codec drivers also tag capture-side gain stages with a bare `volume` capability. On the RT5616 codec, "ADC Boost" lists before the playback controls, so hardware volume changed a capture boost with no audible effect. Accept a bare `volume` element only when it has no capture channels. Co-authored-by: Ricardo Pardini <ricardo@pardini.net> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
balloob
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
On the RT5616 codec, hardware volume picked a capture-side boost control, so volume changes had no effect. Detection now skips bare
volumecontrols that also have capture channels. Minimal version of the fix by @rpardini.Related issue (if applicable):
Types of changes
bugfixnew-featureenhancementbreaking-changerefactordocumentationmaintenancecidependencies🤖 Generated with Claude Code